search

language-transfer / lt-app

React Native application for Language Transfer
https://www.languagetransfer.org/
Other
291 stars 26 forks source link

Download to external storage #46

Open rzasharifi opened 2 years ago

rzasharifi commented 2 years ago

Hello and thanks for your app.

If it possible please add these features:

  1. Dark mode.
  2. Download on external storage.
  3. When I back from lesson to main page, the lesson stops! But I want it continue (I don't know is it bug or not but it's annoying!)
SyntaxBlitz commented 2 years ago

Hi!

Regarding (1) and (3), I've generally designed the app assuming you won't need to spend a whole lot of time interacting with the app's screens. A dark mode wouldn't actually be seen all that much, so I'm not sure it adds much value (especially because the "listen" screen, where you probably spend most of your time in the app, is already colored based on a custom theme for each language, so it wouldn't be affected by dark mode). Similarly, it's intentional that the lesson stops when leaving the "listen" screen, in part because it makes the code simpler but also because there's no reason to use the other screens of the app while you're listening. Since the audio isn't something you'd listen to in the background (like music), I wouldn't want users to get distracted playing with the menus and reading through other text in the app while they're listening to the audio; humans are bad at multitasking, and Language Transfer relies on having your full attention. I expect most usage of the app actually happens while the phone is locked and the audio is playing in the background (that use case is why we made an app at all). Everything else is just boring stuff like data management and settings, which you don't really need to play with while the audio is playing.

I'm open to adding the option to download to external storage. Thanks for the recommendation! I think it would require extra permissions (on Android, at least), but the app could probably request those permissions as it needs them. I wouldn't want the app to require any permissions at download time. I'm going to rename this issue so we're tracking that specific request. PRs are always welcome, but I personally have limited time to devote to development and there are a few other tasks that have a higher priority at the moment.

dennis90a commented 2 years ago

This would def be a good feature, some of us use low end devices with not a lot of storage space.

bufemc commented 1 year ago

I once developed on Android and it was "a pain in the ass" to support external storage, as it was never really well planned by Google. I also work with a device with too less memory, but the SD card. So I add myself to the wish list, however I still can remember how unbelievable bad Google once "implemented" this.