search

languagetool-org / languagetool-browser-addon

LanguageTool Firefox and Chrome Add-on (OUTDATED)
Other
129 stars 53 forks source link

line-height in textarea is changed with an animation #243

Closed Mte90 closed 5 years ago

Mte90 commented 5 years ago

This is creating issues on using the extension on website like https://wordpress.org/support/plugin/polylang/ where in the textarea the text is moving and is impossible to read it. immagine

tiff commented 5 years ago

@Mte90 many thanks. Looking into it now.

tiff commented 5 years ago

@Mte90 We're unable to reproduce this. Which browser are you using? Do you have other browser extensions installed? Thanks in advance.

Mte90 commented 5 years ago

I am using firefox and yes I have different extension installed. I saw that put a domain on whitelist fix the issue but I cannot use your extension.

tiff commented 5 years ago

Can you provide us a list of other extensions you have installed (screenshot of "about:addons")? You can either post this screenshot here or send it to feedback [at] languagetool.org.

Mte90 commented 5 years ago

Screenshot_20190531_125606 Screenshot_20190531_125618

danielnaber commented 5 years ago

Cannot reproduce under Ubuntu with Firefox 68 (beta) and LT add-on 2.1.14

tiff commented 5 years ago

I'm also still not able to reproduce this but might have found the issue why this is happening. A fix will be rolled out soon.

Mte90 commented 5 years ago

I am still facing this problem :-(

tiff commented 5 years ago

Sorry. We are currently preparing a new release where this might be fixed. You can disable checking on the corresponding website by clicking on the "LT" icon in the toolbar.

tiff commented 5 years ago

Update: Firefox has received a new version of our plugin. It will take until mid July until it's rolled out because they're currently making some significant changes to their addons platform.

tiff commented 5 years ago

@Mte90 new version (2.2.0) has been released. Please check if you received it already and whether it is fixed.

Mte90 commented 5 years ago

confirmed that now is working :-)

tiff commented 5 years ago

BTW we now know where this came from and how to reproduce: the default font settings of Firefox were changed (for me it started happen when I changed the minimum font size)

Mte90 commented 4 years ago

I am getting the same issues on the Reddit chat, the line-height change until to 0.1px but if remove that proprierty starts again.

tiff commented 4 years ago

Thanks. Looking into it now.

tiff commented 4 years ago

Happens because Reddit animates "line-height" through a transition: all. We calculate the line-height by reading it via computed style (getComputedStyle). This method behaves differently on Firefox and Chrome:

During CSS transitions, getComputedStyle returns the original property value in Firefox, but the final property value in WebKit.

Source: https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle

We have prepared a fix that will be part of the next release (2-3 weeks).