languagetool-org / languagetool

Style and Grammar Checker for 25+ Languages
https://languagetool.org
GNU Lesser General Public License v2.1
12.33k stars 1.39k forks source link

[LO-Add-on] black window + underlining in wrong position β€” 2024-01-11 #10089

Closed marcoagpinto closed 8 months ago

marcoagpinto commented 9 months ago

Heya, @FredKruse

A few days of testing: I have tested the latest nightly with LibreOffice 24.2.0.1 and its window still gets black with this version of LibreOffice, so probably it is an issue with the add-on.

Also, it underlines in green words in the wrong position and if you right-click them, it doesn't do anything.

See the video attached.

Thanks!

https://github.com/languagetool-org/languagetool/assets/5192600/356bcd2d-5b15-41b3-9ae8-9557afd46b1b

marcoagpinto commented 9 months ago

@FredKruse

The window blackened: vlcsnap-2024-01-12-17h30m27s023

FredKruse commented 9 months ago

The problems with the wrong position and no reaction at right mouse click should be solved. Please test it. The turning black of the window seams to be a LibreOffice problem in combination of functions of LT that needs more time. The LO Window doesn't refresh. I have no idea how I could solve this by LT. The window refreshes if you e.g. change the size of the window.

marcoagpinto commented 9 months ago

Thank you, @FredKruse

My thesis has been causing too much trouble, I guess πŸ˜› πŸ˜› πŸ˜› πŸ˜› πŸ˜› πŸ˜› πŸ˜›

marcoagpinto commented 9 months ago

@FredKruse

I posted, but the post vanished (or maybe I was stressed and didn't press the comment button).

The bug is still happening:

https://github.com/languagetool-org/languagetool/assets/5192600/adce40df-fbae-48f4-8dbe-cba790f70c94 (video with audio)

marcoagpinto commented 9 months ago

At least it now underlines whole words instead of the underlines appearing in the middle of words.

FredKruse commented 9 months ago

@FredKruse

I posted, but the post vanished (or maybe I was stressed and didn't press the comment button).

The bug is still happening:

https://github.com/languagetool-org/languagetool/assets/5192600/adce40df-fbae-48f4-8dbe-cba790f70c94 (video with audio)

This is a bit crazy. I tried to reproduce the bug. But it works well. I tested it under Linux and Windows. Could you try a 'Refresh Check Results'?

marcoagpinto commented 9 months ago

This is a bit crazy. I tried to reproduce the bug. But it works well. I tested it under Linux and Windows. Could you try a 'Refresh Check Results'?

Sure, I will delete the cache.

I will test it at 5am.

πŸ˜› πŸ˜› πŸ˜› πŸ˜›

marcoagpinto commented 9 months ago

@FredKruse

Heya,

It is 100% reproducible here, it doesn't work.

EDIT: Files had classified information, sending you them via e-mail.

https://github.com/languagetool-org/languagetool/assets/5192600/b54b80dd-e38c-429d-8643-e84ea18a93a3

marcoagpinto commented 9 months ago

@FredKruse

And now that we are at it, this .docx always makes the window black, so maybe it will help you fix the black window issue (it is only a one-page document, so it will make things easier to fix).

FredKruse commented 9 months ago

@marcoagpinto I'm very sorry, but I can't reproduce the bug. I did exact what you did in the video. There was no problem (I don't speak Portuguese, but there was definitely a suggestion). The difference in the log file are:

I'm a little helpless and don't know what I can do.

marcoagpinto commented 9 months ago

@FredKruse

I am using LibreOffice prerelease 24.2.0.1, downloadable from LibreOffice's site.

marcoagpinto commented 9 months ago

or what they call RC1 (release candidate 1).

The new versioning on LibreOffice: 2024 February.

FredKruse commented 9 months ago

OK, I think I got it. Now, I had tested the bug with LO Version 24.2.0.1 and could reproduce the problem (with 7.6.4 .2 the check works correct). I did many tests and look what happened. LT gives back the right error when you do a right mouse click. It seems to be a problem with LO 24.2.0.1. It doesn't show the correct context menu, although the grammar checker gives an error back. Would you like to provide feedback to the LO team?

marcoagpinto commented 9 months ago

OK, I think I got it. Now, I had tested the bug with LO Version 24.2.0.1 and could reproduce the problem (with 7.6.4 .2 the check works correct). I did many tests and look what happened. LT gives back the right error when you do a right mouse click. It seems to be a problem with LO 24.2.0.1. It doesn't show the correct context menu, although the grammar checker gives an error back. Would you like to provide feedback to the LO team?

@FredKruse We have a developer who works in LibreOffice, I can't remember his name.

He helped create a fix for that bug that used to eat all RAM.

Let me try to find his name.

marcoagpinto commented 9 months ago

It is @mikekaganski

Mike, would you mind helping us with this for LO 24.2.0.1?

Thanks!

marcoagpinto commented 9 months ago

Ohhhh… Mike lives in Russia, so I don't know about his current condition… Just like Yakov, who never appeared again on GitHub.

mikekaganski commented 9 months ago

Please file it in LibreOffice bug tracker.

A related change is https://gerrit.libreoffice.org/c/core/+/155890 ; it was for Impress/Calc.

marcoagpinto commented 9 months ago

https://bugs.documentfoundation.org/show_bug.cgi?id=159220

mikekaganski commented 9 months ago

Thank you Marco! But please don't create stubs like "Here is the bug; go to another site to read some long-ish discussion to try to understand what it is about". Bug tracker issue should be self-contained, have clear problem description, and clear steps to repro. Thanks!

marcoagpinto commented 9 months ago

Ahhhh... sorry.

marcoagpinto commented 9 months ago

Done!

FredKruse commented 8 months ago

@marcoagpinto Could we close this issue?