Closed marcoagpinto closed 3 months ago
Ahhhh... it now also fixes:
Quero as duas militares.
Quero os dois militares.
"militares" no longer appears as a verb.
Sorry!!!!!!!
I have just fixed it:
Para as duas matares.
If the words are not also nouns, it won't remove them as verbs.
Now it is working again with:
Quero duas garotas.
Quero duas partes.
Quero as duas militares.
Quero os dois militares.
Para as duas matares.
@p-goulart
Pedro, I am so stressed!
π π π π π π π
Thanks!
The rule seems tightly scoped, I doubt this will have many undesired side effects. But do keep an eye on the diff tomorrow morning.
@susanaboatto probably wiser not to include this in a premium deployment, if it does happen later today (I know there may be some changes to the schedule, but just in case.)
Yes, at 5am I will look at the diff to check if some exceptions need to be added.
@p-goulart @susanaboatto
It worked better than expected: https://internal1.languagetool.org/regression-tests/via-http/2024-09-03/pt-BR/ https://internal1.languagetool.org/regression-tests/via-http/2024-09-03/pt-PT/
With such a positive experience, it seems I will βplayβ more with the disambiguation from now on π π π π π π π
I AM SO HAPPY!!!!!
Heya, @susanaboatto , @p-goulart and @jaumeortola ,
I have fixed rare verbs detecting:
"garotas" and "partes" no longer appear as verbs.
But it will impact in the whole core of PT.
That is why I am always scared to change the disambiguator.
But if you believe it is okay, then it is a major improvement, and it will fix tons of false positives in our rules.