coderabbitai[bot]
commented
3 weeks ago Walkthrough
The pull request involves modifications to the spelling.txt file in the Portuguese language module of LanguageTool. New questionable foreign words and terms have been added to the list, with a focus on Portuguese vocabulary. The additions, indicated by a + sign, do not alter existing entries, and no deletions have occurred. The changes were made by Marco A.G. Pinto at the request of Pedro, who aims to enhance the dictionary building process.
Changes
| File | Change Summary |
|---|---|
| languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt | Added new entries for questionable foreign words and terms, including autoevidência and autoevidências. |
Possibly related PRs
- #10917: Adds new entries to the
added.txtandspelling.txtfiles, directly related to the focus on new terms in the main PR. - #10911: Introduces a colloquialism rule in
style.xml, potentially relating to handling new terms in Portuguese. - #10940: Rewrites a rule in
style.xmlto suggest using more formal language, aligning with the goal of enhancing vocabulary correctness. - #10957: Improves disambiguation rules in
style.xml, relevant to the context of new term additions. - #10977: Addresses issues in
disambiguation.xml, which may affect the processing of new terms added. - #10981: Cleans up
disambiguation.xml, ensuring accurate handling of new terms in the language tool's framework.
Suggested reviewers
- p-goulart
- susanaboatto
📜 Recent review details
**Configuration used: CodeRabbit UI** **Review profile: CHILL**📥 Commits
Reviewing files that changed from the base of the PR and between 7bfbc775044abab1212837c124170a84ae2236ee and bcb1e8b5548222f051f3b4e3cb90f1c0a6ffb6bc.📒 Files selected for processing (1)
* `languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt` (1 hunks)🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt (1)
`372-373`: **LGTM! Verify dictionary inclusion.** The additions of "autoevidência" and "autoevidências" follow the file's conventions and maintain alphabetical order. Let's verify if these terms are recognized in Portuguese dictionaries:✅ Verification successful
**The terms follow Portuguese compound word formation rules** Based on the analysis of the Portuguese language files in the codebase: 1. The terms "autoevidência" and "autoevidências" follow the same pattern as other accepted Portuguese compound words with the "auto-" prefix 2. The codebase shows many examples of similar compound words in Portuguese that don't use hyphens (e.g., "autoajuda", "autoavaliação", "autoestima") 3. The terms are consistent with the Portuguese spelling reform rules as evidenced by the `AOreplace.txt` file which shows the trend of removing hyphens from "auto-" compounds🏁 Scripts executed
The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Search for existing usage of these terms in the codebase # and other dictionary files to ensure consistency # Search for any existing references to these terms rg -i "autoevidência|autoevidências" # Check if these terms exist in other Portuguese dictionary files fd -e dic -e dict -e txt . | grep -i "pt.*dict" | xargs grep -i "autoevidência" ``` Length of output: 345 --- Script: ```shell #!/bin/bash # Let's try a different approach to verify these terms: # 1. Check for any compound words starting with "auto" in Portuguese dictionary files fd . -e txt -e dic -e dict | grep -i "pt" | xargs grep -i "^auto" 2>/dev/null # 2. Look for spelling/dictionary configuration files that might define compound word rules fd . -e xml -e conf | grep -i "pt.*spell" | xargs cat 2>/dev/null # 3. Check if there are any test cases or examples using these terms rg -i "autoevidência" -g "*.xml" -g "*.txt" -g "*.properties" # 4. Look for documentation about Portuguese compound words fd . -e md -e txt | grep -i "readme\|doc" | xargs grep -i "compound.*word" 2>/dev/null ``` Length of output: 43584Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
marcoagpinto
Words missing for years, and the singular one appears in a document I have been writing. It was about time I added it.
Summary by CodeRabbit
autoevidênciaandautoevidências.