Closed marcoagpinto closed 2 weeks ago
This pull request introduces extensive modifications to the disambiguation.xml
file for Portuguese grammar rules in LanguageTool. Key updates include a change in copyright information, a simplified language description, and improved clarity in comments. The XML structure remains largely intact, while several existing rules have been modified or commented out, and new rules for conjunctions and adverbs have been added. The changes aim to modernize the documentation and enhance the handling of specific grammatical cases.
File Path | Change Summary |
---|---|
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml | - Updated copyright information in the header. - Simplified description from "Portuguese (Portugal - prereform + postreform)" to "Portuguese." - Added reference to tagset.txt . - Revised comments for clarity. - Retained and modified existing rules, with some commented out. - Introduced new rules for conjunctions and adverbs. |
disambiguation.xml
for handling specific verb forms, related to the main PR's updates.disambiguation.xml
, aligning with the focus on clarity in the main PR.disambiguation.xml
, relevant to the refinement of grammatical rules in the main PR.RARE_POS
rule in disambiguation.xml
, reflecting improvements in handling verbs and nouns.RARE_POS
group, enhancing disambiguation logic for verbs and nouns, connected to the main PR.RARE_POS
rule related to verb and noun detection, aligning with the main PR's objectives.RARE_POS
group and improves comments, relevant to the updates in disambiguation.xml
.Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
"Catalan" makes my checks fail.
@jaumeortola @susanaboatto @p-goulart
It DIDN'T break Premium!
I believe now that the most serious issues regarding incorrect nouns/verbs are fixed.
I will only create more rules regarding them if I find while developing rules.
Heya,
Another major improvement.
I will only merge it after the “tree becomes green” in the commits, since I am seeing several commits there with failures.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
tagset.txt
for additional context.