search

languagetool-org / languagetool

Style and Grammar Checker for 25+ Languages
https://languagetool.org
GNU Lesser General Public License v2.1
12.46k stars 1.4k forks source link

[pt] More verbs/nouns fixes in disambiguation.xml #11042

Closed marcoagpinto closed 5 days ago

marcoagpinto commented 5 days ago

More tons of fixes.

Summary by CodeRabbit

coderabbitai[bot] commented 5 days ago

Walkthrough

The pull request introduces changes to the disambiguation.xml file for Portuguese grammar rules in LanguageTool. It primarily involves renaming a rule from PELA_COMO_SOBRE_VERBS_RARE to PELA_COMO_SOBRE_NADA_VERBS_RARE, thereby expanding its scope to include the token "nada". The associated comments have been updated for clarity, and minor formatting adjustments have been made. No new rules were added or removed, and the overall structure of existing rules remains unchanged.

Changes

File Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml Renamed rule PELA_COMO_SOBRE_VERBS_RARE to PELA_COMO_SOBRE_NADA_VERBS_RARE; updated comments and formatting.

Possibly related PRs

Suggested reviewers

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 59c44ce51d45b3080fa624b0e2848bfd5d088ffc and a8dd376b5d9150adcfa59ea7b701e2ddec0f2b0c.
📒 Files selected for processing (1) * `languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml` (1 hunks)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1) `3816-3823`: **LGTM! The rule expansion improves coverage.** The changes look good - expanding the rule to handle "nada" token makes sense and the examples in the comments verify this behavior is correct. Let's verify there are no conflicts with other rules handling "nada":
✅ Verification successful Let me analyze the search results for "nada" in the Portuguese language resources: 1. The word "nada" appears in several contexts: - As part of the rule ID `PELA_COMO_SOBRE_NADA_VERBS_RARE` in disambiguation.xml - In hyphenated compounds like "bem-nada", "todo-nada", "tudo-nada", "quase-nada" - In multiwords.txt as "mais nada" - In entities/misc.ent as part of negation words and other patterns - In common_words.txt as a common word - In confusion_set_candidates.txt in various word pairs The search results show that "nada" is properly handled across different Portuguese language resources, and the addition of "nada" to the rule `PELA_COMO_SOBRE_NADA_VERBS_RARE` is consistent with the existing language patterns and doesn't conflict with other rules. **The rule expansion to include "nada" is valid and well-integrated** The change improves disambiguation by preventing "nada" from being incorrectly tagged as a verb when it follows a participle/infinitive, similar to how "pela", "como", and "sobre" are handled.
🏁 Scripts executed The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Check for other rules that may conflict with the expanded pattern # Search for other rules handling "nada" rg -A 5 'nada' 'languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/' ``` Length of output: 154207

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.