languagetool-org / languagetool

Style and Grammar Checker for 25+ Languages
https://languagetool.org
GNU Lesser General Public License v2.1
12.28k stars 1.39k forks source link

[server] Logging - logback #2127

Open black-snow opened 4 years ago

black-snow commented 4 years ago

The server prints to stdout and stderr although we have slf4j/logback at hand.

I fixed this by:

I also had to delete languagetool-server/src/main/resources/logback.xml, otherwise my provided logback config -Dlogback.configurationFile=logback.xml would not be used.

I'll file a PR if you're interested.

In the long run we should probably also consider using the log levels properly. I modified the ServerTool's print() to use info/error depending on wether PrintStream is System.err or not but we can do better.

/edit: This seems related.

danielnaber commented 4 years ago

I'll file a PR if you're interested.

Yes, please do.

black-snow commented 4 years ago

https://github.com/languagetool-org/languagetool/pull/2128