[en] False warnings in rulegroups IT_IS and IT_IS_2

MikeUnwalla commented 4 years ago

After I removed duplicate warnings, 49 warnings remained in ITS_JJ_NNSNN. Of those, 35 are false warnings:

[ ] And oh, by the way, it's federal taxes and the military industrial complex which has funded CA's weapons industry and communications industry.
[ ] It's real money to us.
[ ] I assume it's common practice to have to go through this process due to our group's move from one company to another, but have been asked by one of our originators if there's a way to work around it; the point being that it's an inconvenience to the counterparty to jump through another hoop because of our situation.
[ ] Because it's good politics.
[ ] It's doubtful anything will get done here today.
[ ] The report is that it's healthy marrow.
[ ] Historians think it’s possible hotcakes were relegated to the morning because they are much quicker to prepare than bread.
[ ] Just remember, contestants, it's good advice to go with your first instinct.
[ ] It's stupid pledges with insufficient guidance from the leaders of the Auburn chapter that lead to this discussion.
[ ] Muslims don't eat pork because it's dangerous meat.
[ ] It's profound ignorance that inspires the dogmatic tone of speaking.
[ ] Do you think it's worth something?
[ ] It's good teamwork again.
[ ] It's great news to see that people who voted for Al Gore and even elected officials from his own party breaking ranks.
[ ] Yes, it's premium time again.
[ ] It's common knowledge that the earth turns on its axis.
[ ] It's poor form to spit from the window into the street, or into the fire, or anywhere people might step on what you have spit.
[ ] It's real conservation that is taking place," Freeman said.
[ ] Sarah, Let's get her an interview schedule if you think it's worthwhile Thanks.
[ ] It's bigoted idiots with power.
[ ] Whether it's national economics, family economics, or personal economics, it's not something where sloppy accounting is good enough.
[ ] It's human nature to want what your neighbor has.
[ ] It's common knowledge that you don't like Tom.
[ ] For some it's unspoiled beaches and lush tropical jungle.
[ ] This work placed comparative law in it's historical context and was widely read and influential.
[ ] It's human nature to want bigger, better and more.
[ ] It's common knowledge that bears like honey.
[ ] It's good exercise to climb hills.
[ ] The question is whether it's legal greed or illegal greed.
[ ] It's possible things will get worse.
[ ] Some of this you'll understand all too well and other parts you may not have experienced yet, but I think it's good advice no matter what point you're at in your life.
[ ] It's pure malarkey that that's too much.
[ ] For some it's legal reasons, others just because they want to, or that's where the work is.
[ ] They tell me that it's good exercise, but I'm just not into jogging.
[ ] Clearly, it's corporate management doing the hiring and firing of auditors.

TRUE ERRORS

Once we get the above resolved we still have no way or extracting the vega or gamma risk from Portcalc in it's current state as the information is just no there (so we are told by IT).
It is very disappointing that so much effort would be put into flying a pump from the US to Europe and then so little effort put into trucking the same pump to it's final destination within Europe.
Texas picked up it's 13th commitment of the season when Chase Pittman pledged to Texas.
I think my role (on the board) will help the state solve it's serious generation shortage problem," Freeman said.
It's good idea to avoid all New England tailbacks at this point in the season. [Incorrect grammar, missing article.]
On a different note, my firm has continued to expand it's business practices.
So many people have expressed a desire to know more about the University (it's new initiatives and successes) that President Bush volunteered to host a gathering of 25 CEOs and spouses (or a second person in the corporate hierarchy).
Her hair grew back to it's original length.
Southeastern's efforts were foiled, however, when Aetna sold off it's financial services arm, while holding on to its health care operations.
It's two-hour drive from here to my uncle's house. [Incorrect grammar, missing article.]
We feel that the above investment represents the capital PDSE requires to continue to effectively launch it's new strategy.
When developers need to change the behavior of an object they can localize the change to just that object and it's component parts.
So many people have expressed a desire to become know more about the University (it's new initiatives and successes) that President Bush volunteered to host a gathering of 25 CEOs and spouses (or a second person in the corporate hierarchy).
Now in it's 10th year, Gartner Symposium/ITxpo is widely recognized as the most comprehensive IT strategy event in the world, attracting the industry's leading analysts, strategists and practitioners.

udomai commented 4 years ago

Oh, wow! I think this needs to be fixed, it does not a shed a good light onto LT if we don't get that right. No need to panic though, its deactivation rate has been 2 % (apply rate 69 %, 468 times opened over the last 7 days) and Matomo shows that out of 6 deactivations this week, half were actually correct warnings. @MikeUnwalla , how could we go about this? It seems hard to condense those FP into only a few antipatterns... can the rule maybe be more specific (at the price of risking more FN)? Like focusing on the pattern of ITS_JJ_NNSNN immediately followed by a VBZ?

MikeUnwalla commented 4 years ago

Rulegroup IT_IS has more than 50 rules. When I prevent ITS_JJ_NNSNN from finding any match, some of those rules find the true errors.

As you write, if we make the rule more restrictive by expanding the pattern, then LT will not find some errors. But, eventually, we will make more rules (when someone complains about a false negative).

You are right that we can't solve the problem with only a few AP. But, I think the best way to solve the problem is to add AP (even if there are many of them). Our choice is one of these:

One rule with many APs
Many rules

udomai commented 4 years ago

I would go for the APs then. It's the more hands-on approach and I guess it's less prone to cause priority issues. When I will be looking at the performances (application vs. deactivation) of rules concerning its vs. it's to see which rules should be fixed first, I can collect an overview of deactivation contexts for writing APs.

MikeUnwalla commented 4 years ago

FP in other rules in rulegroup IT_IS. I ignored FP in texts where the grammar was incorrect.

IT_IS[10]

[ ] That same year, 1987, the company introduced its Mega Man series.

IT_IS[18]

[ ] Barron's reported over the weekend that Dynegy may have a difficult time walking away from the deal because its right to the pipeline might be challenged by J.P. Morgan Chase & Co.
[ ] ...in 1994 with a jury finding for AMD and its right to use Intel's microcode in...

IT_IS[22]

[ ] Its nearest neighbors are the French islands of Guadeloupe, some north, and Martinique, about south.
[ ] Its nearest competitors, MSN (7 million subscribers), United Online (6.1 million subscribers) and Earthlink (ELNK) (4.9 million subscribers) will battle it out for second place.
[ ] Its outside wall features the oldest known coat of arms, which is of 1664.
[ ] Its nearest landmass is Cape Hatteras, North Carolina, about to the west-northwest.
[ ] Its past private equity investments include Mpower Communications, Tele1 Europe Holding A.B., Verio, Brooks Fiber Properties, and Western Wireless.
[ ] Its nearest neighbor is Howland Island, to the north-northwest; both have been territories of the United States since 1857.

IT_IS[25]

[ ] ...n the event that People's does not fund its half.
[ ] Enron is in talks to sell its half stake in a natural gas venture with SK Corp., an official of Korea's top oil refiner said.
[ ] ...arlin's primary asset is supposed to be its half of Azurix.
[ ] Wednesday had the company expanding its Half.com division to consumer electronics and sporting goods from books, music, movies and video games.
[ ] There would be a business contract between Enron Networks and MFN covering such its as pricing, specific services, payment obligations and a prohibition against placing liens on the property.

IT_IS[27]

[ ] Its graphing mechanism consisted of a rotating drum of paper equipped with a marking needle.
[ ] Successful viewing of a page is not necessarily an indication that its encoding is specified correctly.
[ ] The dormitory lay along the Charles River and its undulating form provided maximum view and ventilation for each resident.
[ ] Despite the delays caused by heat and malaria, it was completed in November 1511, its surviving door known as "A Famosa" ('the beautiful').
[ ] Modulation was usually accomplished by a carbon microphone inserted directly in the antenna or ground wire; its varying resistance varied the current to the antenna.
[ ] Res.242, Recognizing Radio Free Europe/Radio Liberty's success in promoting democracy and its continuing contribution to 5021.
[ ] Currently, WBBM (780 AM) and its simulcasting partner, WCFS-FM (105.9 FM) broadcast Bears games with Jeff Joniak doing the play-by-play...
[ ] Accounting firm Andersen said Wednesday that its auditing practice responsible for checking the books of bankrupt energy trader Enron Corp. has been given a clean bill of health.
[ ] If the market interprets the Fed as suggesting that its easing cycle is about to end, the stock market's focus will likely shift back to corporate earnings.
[ ] MSNBC was among the first of the mainstream outlets to recount the deception and its unraveling.
[ ] ... a link between the peptide variant and its encoding gene.
[ ] In the 2006–2007 company-wide story arc "Civil War", and its anchoring, seven-issue miniseries, Civil War (July 2006 - Jan. 2007), Rogers opposes the...
[ ] The relationship between an inner class and its containing class can also be treated as another type of class association.
[ ] Moreover, its triggering mechanism is not yet clear.
[ ] ...articipant in the United Nations, where its voting record demonstrates its commitme...

IT_IS[28]

[ ] Enron's board, for example, gave its okay.

IT_IS[30]

[ ] In this kind of weather it's best if I stay at home and don't go outside.
[ ] Steve, I understand that you are out today; I hope it's vacation.

IT_IS[37]

[ ] ...ated for core customers if the value of its A/R falls below the amount owed to gas ...
[ ] This could impact all of our A/S business if the ISO feels that EPMI is not able to meet its A/S obligation to the ISO on a consistent basis.
[ ] Enron Executives Knew of Losses Enron's top executives and board of directors knew as early as March that its off the books partnerships were losing money.

IT_IS[38]

[ ] As I review your options below it's hard to decide what we have to give up.

IT_IS[42]

[ ] New terms may not be necessary if Enron can get the additional $2 billion in financing it's seeking, some investors said.
[ ] But all that has to wait until we get this house finished and figure out if we are making any money in this business, being it's our first year and Armin's parents made us take the business without EVER seeing a balance sheet.
[ ] After the two hour session, it appeared to me that the team was probably overstaffed and still adding to its girth, fulfilling IT's roles in some cases...

IT_IS[43]

[ ] Sheperdson, however, believes it's clear that electricity costs are on the rise.
[ ] They'll be vulnerable to further declines until it's clear that the economy has completed its downswing.
[ ] And with five kids it's hard not to use power.
[ ] Free movies each Tuesday at 8PM on the backyard screen (if it rains it's indoors). [Missing comma.]
[ ] All I remember is it's near the east side of the Hawthorne Bridge. [Missing comma.]
[ ] Tom believes it's simpler than that.

IT_IS[44]

[ ] RWE has said it's exploring acquisition possibilities in Europe and overseas to expand outside its home market.
[ ] Chairman Oxley has said it's something we're going to have to address before Congress adjourns.
[ ] The shoulder is still a little sore, but he said it's getting better all the time.
[ ] ... energy officials and experts testifying before the committee have said it's unlikely investors would buy aging power plants if they believed that to be true.
[ ] But commission members acknowledged it's unlikely legislators will tackle the complex plan next year when they are struggling with a budget shortfall...

IT_IS[46]

[ ] Despite its small size (roughly from its northernmost to southernmost points), t...

IT_IS[7]

[ ] Though we really don't expect either campaign to talk about it (and would discourage them from doing so), the message here is it's time to start planning for a possible presidential transition...
[ ] My guess is it's an all day affair getting from a little island to DC so we may get in pretty late.
[ ] We've said all along it's a crisis inspired by the greed of the utilities and the energy companies," Rosenfield said.
[ ] Bottom line is it's the same place we talked about earlier this week.

IT_IS[9]

[ ] It is noted for its great, canoe-shaped bill and its bright...

TO_VB_ITS_NN[50]

[ ] I'm not willing to say it's fraud yet," Ellinghaus said.
[ ] Even so, she added, ``that's not to say it's anything illegal.
[ ] I'm going to guess it's membership dues," she said. [Semantic ambiguity.]

udomai commented 4 years ago

Thank you, Mike! That is super helpful. I will give you feedback from the user statistics standpoint when you'll be back from your holidays :)

MikeUnwalla commented 4 years ago

False warnings in rulegroup IT_IS_2.

(Aside: why are there 2 rulegroups? Should we have only one??

IT_IS_2[12] The warnings for 'its' are correct. Many of the warnings for 'it' are not correct, because the text uses the subjunctive (www.lexico.com/grammar/when-to-use-the-subjunctive). Split the rule, and change the message for 'it'.

IT_IS_2[15]

[ ] Dynegy Inc. is close to finalizing a deal to buy its much larger, albeit troubled, rival Enron Corp.

IT_IS_2[16]

[ ] In contrast, the Los Angeles Department of Water and Power (LADWP), the municipal utility that primarily serves the greater Los Angeles metro area, announced that its more than 3.7 million businesses and residences are enjoying stable electricity prices and a plentiful supply heading into the holiday season.

IT_IS_2[17]

[ ] ... agreeing to buy the Enron Corporation, its much larger crosstown rival, for more t...

IT_IS_2[26]

[ ] It's hand held wireless investing that lets you access your account, get news and quotes, place trades and more.

IT_IS_2[6]

[ ] The Commission held over until its next meeting the decision regarding the rate agreement between DWR and the PUC.
[ ] ...e to the club's premiership success and its being the dominant Queensland team in t...

IT_IS_2[8]

[ ] The Sabbath: Its Meaning for Modern Man.
[ ] ...mnify, defend, and hold harmless TW and its Indemnified from and against any and al...
[ ] Divisibility properties of the Bernoulli numbers are related to the ideal class groups of cyclotomic fields by a theorem of Kummer and its strengthening in the Herbrand-Ribet theorem, and to class numbers of real quadratic fields by Ankeny–Artin–Chowla.
[ ] The brioche is like the bastard child of sponge cake and bread, but its feeling under the tongue is the best under the heavens.
[ ] After its decommissioning as a gas chamber, the building was converted to a storage facility and later served as an air raid shelter for the SS.

languagetool-org / languagetool

[en] False warnings in rulegroups IT_IS and IT_IS_2 #3467