languagetool-org / languagetool

Style and Grammar Checker for 25+ Languages
https://languagetool.org
GNU Lesser General Public License v2.1
11.84k stars 1.38k forks source link

[pt] rules with many temp_disables #6921

Open susanaboatto opened 2 years ago

susanaboatto commented 2 years ago

Marco:

marcoagpinto commented 2 years ago

The GENDER AGREEMENT will still take me weeks to fix as I have to rewrite all antipatterns and the same for the NUMBER AGREEMENT.

The rule that suggests adding a “!” after each interjection is very annoying, if you think it is useless, please delete it… every time one writes: “Olá, Marco.” it suggests adding a “!” to “Olá”.

marcoagpinto commented 2 years ago

Some of these rules can be moved to pt-PT.

marcoagpinto commented 2 years ago

But the “Olá!” should probably be deleted.

marcoagpinto commented 2 years ago

@jaumeortola @susanaboatto @udomai @tiff @danielnaber @ricardojosehlima

I have been looking at the GENDER and NUMBER agreement rules.

They have not dozens, but probably hundreds of antipatterns.

I will have to test one by one, starting with the oldest antipatterns, since their results are probably replaced by newer antipatterns.

Since I am testing against 600 000 sentences, it will take months and not weeks, but it will eventually get done.

Not much I can do to speed up the task… I really have to test antipattern by antipattern.

What I can do is to alternate between GENDER and NUMBER to try to “kill” globally (reach more users in a general way).

susanaboatto commented 1 year ago

Hi @marcoagpinto a while ago I moved the rule INFORMALITIES to the PT-PT grammar. The numbers still don't look so good. Would you mind taking a look at it? If there's nothing to be done there, we should probably deactivate it.

marcoagpinto commented 1 year ago

@susanaboatto

Sure, turn it "default=off", I will have a look at it in a few days.

Thanks!

marcoagpinto commented 1 year ago

Right now, I am fixing the antipatterns of NUMBER AGREEMENT.

And I want to create two new rules before the INFORMALITIES.

❤️

susanaboatto commented 1 year ago

Awesome, many thanks! I have set INFORMALITIESoff. Are your new rules for the pt-pt grammar or would they also include pt-br?

marcoagpinto commented 1 year ago

@susanaboatto

The two rules are for BR + PT, but I will only be able to code them with the help of @ricardojosehlima .

He must be busy right now, since he didn't reply to one of them.

The other one the idea is still in text, and I will ask for his opinion first.

susanaboatto commented 1 year ago

@marcoagpinto Where did you ask him? Maybe I can help?

marcoagpinto commented 1 year ago

@susanaboatto

https://github.com/languagetool-org/languagetool/issues/6966

Basically, what I really need is a good rule ID, rule name, and suggestion message.

Then I will need help to see which verbs can be used with the results… it will probably return a lot of results (I hope 😄 ), then we need to look at them to see the verbs it can be used with.

Thanks!

marcoagpinto commented 1 year ago

@susanaboatto

I have solved the INFORMALITIES being disabled by users: https://github.com/languagetool-org/languagetool/commit/745886d39715c889a724acf20518e8a5c2e52193

Now I will slowly add valid words to the new entity.