search

languagetool-org / languagetool

Style and Grammar Checker for 25+ Languages
https://languagetool.org
GNU Lesser General Public License v2.1
12.03k stars 1.38k forks source link

[nl] unexpected uppercase suggestion #8953

Open ghost opened 1 year ago

ghost commented 1 year ago

afbeelding

is last night's diff from

afbeelding

Has something automagically change in the 'alllower' ?

danielnaber commented 1 year ago

Yes, @jaumeortola can probably tell you how to avoid the all-uppercase suggestions-

ghost commented 1 year ago

The change should not overrule an explicit xml statement to suggest allower.One solution might be to ignore suggestions with spaces in the new code. Op 15 jul. 2023 09:59 schreef Daniel Naber @.***>: Yes, @jaumeortola can probably tell you how to avoid the all-uppercase suggestions-

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

jaumeortola commented 1 year ago

To avoid all-uppercase suggestions, now you need to use a <match> with the attribute case_conversion at the start of the first suggestion (https://github.com/languagetool-org/languagetool/issues/7125#issuecomment-1637177633).

ghost commented 1 year ago

I don't understand. I explicitly command part of the suggestion to be lowercase, but that is overruled?

Could you please edit the mentioned Dutch rule to demonstrate?

mark-baas commented 1 year ago

I'll modify the rule, I've done it with another to avoid unnecessary caps.

ghost commented 1 year ago

Jaume already did this.Op 17 jul. 2023 10:17 schreef mark-baas @.***>: I'll modify the rule, I've done it with another to avoid unnecessary caps.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

jaumeortola commented 1 year ago

I explicitly command part of the suggestion to be lowercase, but that is overruled? I still consider it a bug though, since en explicitly states alllower, and still turns up all upper. When a statement does not lead to the specified output, it is a bug.

I know. I could change the logic of the implementation and do this: if any part of any suggestion has a case_conversion attribute, then do not suggest all-uppercase replacements at all. But I'm afraid it will cause many undesired results in many languages. I will test it anyway.