languagetool-org / portuguese-pos-dict

Portuguese POS tagger
GNU Lesser General Public License v2.1
5 stars 2 forks source link

[pt-PT] Added irregular verb rules to the A45 and A90 .AFFs #17

Closed marcoagpinto closed 8 months ago

marcoagpinto commented 8 months ago

Heya, @susanaboatto and @p-goulart

Here is a new set of rules for irregular verbs pt-PT.

Almost 200 new forms have been added.

According to the e-mail reply of Pedro, I have fixed the rule for:

fusé-la
fusé-las
fusé-lo
fusé-los

Those four verbal forms have been removed:

SFX P   or              usé-la          [^f]or
SFX P   or              usé-las         [^f]or
SFX P   or              usé-lo          [^f]or
SFX P   or              usé-los         [^f]or

I added: [^f] and only these four were affected.

Thanks!

p-goulart commented 8 months ago

@marcoagpinto do you mind fixing fusé-lo for pt-BR.aff as well, since you know what rule it is? :p I suppose if you copied it from pt-BR it's also wrong there.

Also I think maybe [^f] is overkill. Surely just por would be enough? This pattern is exclusive to .+por -> .+puser.

marcoagpinto commented 8 months ago

@marcoagpinto do you mind fixing fusé-lo for pt-BR.aff as well, since you know what rule it is? :p I suppose if you copied it from pt-BR it's also wrong there.

Also I think maybe [^f] is overkill. Surely just por would be enough? This pattern is exclusive to .+por -> .+puser.

Ahhhhh… that is exactly what I was thinking about, fixing the pt-BR rule too.

Give me 20 minutes for some testing.

marcoagpinto commented 8 months ago

@p-goulart

I screwed up!

I thought I had the most recent pt-BR .AFF, so I tried to replace mine with the one on the repository and it was very different.

Maybe you can change it directly?

It is the lines:

SFX r   or       usé-la          por
SFX r   or       usé-las         por
SFX r   or       usé-lo          por
SFX r   or       usé-los         por

Just search for: SFX r or usé-la And you will find them.

marcoagpinto commented 8 months ago

I pressed CANCEL in the pull request window of TortoiseGit and I can't get back the pt-BR. AFF

marcoagpinto commented 8 months ago

I opened another branch, I couldn't undo what I did.