Closed Mynacol closed 1 month ago
Thanks for the fix.
Before this can be merged, you need to reword your commit message to match the commit convention of the project. Could become something like "fix(kodi-idle-time): send proper requests"
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.71%. Comparing base (
88f35c3
) to head (8bb6dad
). Report is 11 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for updating. Still a few things that wouldn't match the convention, but these are minor. The important part is the commit type in the first line as releases are based on the type of commit. I'll ignore the rest of the linting errors and merge this now.
:tada: This PR is included in version 7.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
This commit fixes a syntax error in the request sent to Kodi in the KodiIdleTime check. A sample request from autosuspend is following:
{{"jsonrpc": "2.0", "id": 1, "method": "XBMC.GetInfoBooleans","params": {"booleans": ["System.IdleTime(300)"]}}
It has a surplus opening curly brace at the beginning, leading Kodi to ignore the request with the following log entry:
error <general>: JSONRPC: Failed to parse [the above request]
This leads to the following exception in autosuspend: