search

langx / langx-flutter

Here is the Flutter-based version of the LangX application, originally developed using the Ionic Angular framework.
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

my profile ui #20

Closed Addison1 closed 2 months ago

Addison1 commented 2 months ago

Pull Request Template

Description

first my profile ui

Related Issue

Link to the issue here: #(issue)

Type of Change

Checklist

Additional Notes

Any additional information.

Reviewers

xue

xuelink commented 2 months ago

@Addison1 can you please fix flutter analyze issue ? 

Run flutter analyze
Analyzing langx-flutter...                                      

   info • The file name 'Shield_svg.dart' isn't a lower_case_with_underscores identifier • lib/components/Shield_svg.dart:1:1 • file_names
   info • Unnecessary 'const' keyword • lib/components/profile_study_languages_card.dart:31:19 • unnecessary_const

2 issues found. (ran in 9.7s)
Error: Process completed with exit code 1.
xuelink commented 2 months ago

image

love your work

xuelink commented 2 months ago

Before merge this PR, can you please fix for the dark mode UI @Addison1

https://github.com/langx/langx-flutter/assets/3280475/36101660-f416-42ba-862b-5f3277938305

DH-555 commented 2 months ago

I think it's used automatically?

DH-555 commented 2 months ago

Oh, I think that the theme is what needs the change. Let's merge this

xuelink commented 2 months ago

I think it's used automatically?

Nope,i added and removed. PR wont close this issue, only it will do checked in checklist in the first post here now.

xuelink commented 2 months ago 
To inspect this widget in Flutter DevTools, visit:
http://127.0.0.1:9101/#/inspector?uri=http%3A%2F%2F127.0.0.1%3A49671%2FBkvcLigkMlc%3D%2F&inspectorRef=inspector-0

The overflowing RenderFlex has an orientation of Axis.vertical.
The edge of the RenderFlex that is overflowing has been marked in the rendering with a yellow and
black striped pattern. This is usually caused by the contents being too big for the RenderFlex.
Consider applying a flex factor (e.g. using an Expanded widget) to force the children of the
RenderFlex to fit within the available space instead of being sized to their natural size.
This is considered an error condition because it indicates that there is content that cannot be
seen. If the content is legitimately bigger than the available space, consider clipping it with a
ClipRect widget before putting it in the flex, or using a scrollable container rather than a Flex,
like a ListView.
The specific RenderFlex in question is: RenderFlex#a6186 OVERFLOWING:
  creator: Column ← Padding ← Semantics ← DefaultTextStyle ← AnimatedDefaultTextStyle ←
    _InkFeatures-[GlobalKey#f9d5d ink renderer] ← NotificationListener<LayoutChangedNotification> ←
    CustomPaint ← _ShapeBorderPaint ← PhysicalShape ← _MaterialInterior ← Material ← ⋯
  parentData: offset=Offset(16.0, 16.0) (can use size)
  constraints: BoxConstraints(w=315.0, h=510.0)
  size: Size(315.0, 510.0)
  direction: vertical
  mainAxisAlignment: start
  mainAxisSize: max
  crossAxisAlignment: center
  verticalDirection: down
◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤
════════════════════════════════════════════════════════════════════════════════════════════════════

Another exception was thrown: A RenderFlex overflowed by 5.0 pixels on the bottom.

Oh, I think that the theme is what needs the change. Let's merge this

At least, we can fix that one here before merging.

xuelink commented 2 months ago

@DH-555 If you update theme.dart within this PR, gonna be awesome as well!

DH-555 commented 2 months ago

🆗

xuelink commented 2 months ago

Ok, guys, im going to merge this repo for further, we can open new PR's spesifically additions for dark theme and other issues for sure!