langx / website

This is the official website of langx.io
https://langx.io
MIT License
16 stars 9 forks source link

adds dark and light svg logo to header #47

Closed jakebogan01 closed 7 months ago

jakebogan01 commented 7 months ago

I went ahead and added a light and dark logo to the header. I commented out the old SVG logo as well as the light SVG logo, leaving the dark logo up to view. I also switched where the link tag is, so it only wraps around the logo and doesn't span across the header.

xuelink commented 7 months ago
Screenshot 2024-04-11 at 1 20 36 AM Screenshot 2024-04-11 at 1 20 47 AM

@jakebogan01 dark and light mode looks like that

jakebogan01 commented 7 months ago

@xuelink The dark mode logo looks great, the light logo looks to be bugging out. It's suppose to look like this, ignore the white background I just quickly opened up the SVG and took a screenshot of it:

Screenshot 2024-04-10 at 6 26 51 PM

I also just checked the SVG again and it looks fine on my end, not sure why its looking like that for you

xuelink commented 7 months ago

@jakebogan01 for both of them, it can stay the same because we are not changing the color of headers for both themes, i think it is also better to use it without background something like https://github.com/langxapp/branding/blob/main/app-resources/icon-foreground.png

xuelink commented 7 months ago

@jakebogan01 for example in our social media posts, its used like that for the yellow background and header of the website also doesnt change for the dark/light theme. We can use it the same here as well ;)

Screenshot 2024-04-11 at 1 34 30 AM
jakebogan01 commented 7 months ago

@xuelink I understand, I will remove the dark logo and keep the other one. I'll have the logo look just like that 👍

jakebogan01 commented 7 months ago

@xuelink I removed the dark and old SVG logo and replaced it with a normal logo as referenced in your image above. Ready for your review

xuelink commented 7 months ago

@jakebogan01 If you are agree with that, i can attach new commit here to fix it and merge it ;) Best

jakebogan01 commented 7 months ago

@xuelink I tried to replicate that issue, the logo doesn't change based on the theme for me. What browser are you using?

https://github.com/langxapp/website/assets/66225768/18900b02-42ab-4d9a-977c-4ef07433c65f

xuelink commented 7 months ago

@jakebogan01 adding fill="#000" related parts of svg fixed. https://github.com/langxapp/website/pull/47/commits/c1b08660f0afa27fce5a69b31ac37544c3b78590

My Browser:

Screenshot 2024-04-12 at 5 54 14 PM
xuelink commented 7 months ago

@jakebogan01 We are also talking about this repo on DG, #codebase channel, Feel free to join: invitation

jakebogan01 commented 7 months ago

@xuelink thanks for fixing that. Should have thought about that myself. Thanks again, I'll take a look at that today