search

lanl-ansi / Alpine.jl

A Julia/JuMP-based Global Optimization Solver for Non-convex Programs
https://lanl-ansi.github.io/Alpine.jl/latest/
Other
244 stars 39 forks source link

NLobjective_bug #124

Closed harshangrjn closed 5 years ago

harshangrjn commented 5 years ago

Fix for #123

harshangrjn commented 5 years ago

@kaarthiksundar Does this look good or anything I am missing?

kaarthiksundar commented 5 years ago

The fix is fine.

codecov[bot] commented 5 years ago

Codecov Report

Merging #124 into master will not change coverage. The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files          15       15           
  Lines        3132     3132           
=======================================
  Hits         2420     2420           
  Misses        712      712
Impacted Files Coverage Δ
src/operators.jl 74.82% <87.5%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b197004...7ebe18f. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #124 into master will not change coverage. The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files          15       15           
  Lines        3132     3132           
=======================================
  Hits         2420     2420           
  Misses        712      712
Impacted Files Coverage Δ
src/operators.jl 74.82% <87.5%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b197004...7ebe18f. Read the comment docs.

harshangrjn commented 5 years ago
  1. Bug fix in NLobjective parsing.
  2. Removed Dynamic_partitions_github.png