Closed KristofferC closed 5 years ago
Merging #132 into master will increase coverage by
<.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 77.08% 77.09% +<.01%
==========================================
Files 15 15
Lines 3155 3152 -3
==========================================
- Hits 2432 2430 -2
+ Misses 723 722 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/solver.jl | 97.83% <ø> (+0.39%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4078aaf...6412ae0. Read the comment docs.
On more careful examination, this is the result of a bugfix in deepcopy
with mutable structs being considered non-singleton (https://github.com/JuliaLang/julia/pull/31825).
The lines at:
makes the check for ==
with empty_solver
be false. I believe this is a correct bugfix for the problem shown by the test failure.
Thanks @KristofferC for catching this.
When running the tests for this package on the upcoming 1.3 release I got the error:
I tracked it down to the following issue https://github.com/JuliaLang/julia/issues/33359.
This PR works around the problem.