Closed julbinb closed 3 years ago
@julbinb Thanks for your helpful suggestions. I have updated the code and eliminated the usage of evals as much as possible. If you get a chance to review the recent release (v0.2.0) and see if this needs any more changes, let me know and I shall get them fixed. If not, will close the issue.
@harshangrjn you are welcome! I will try to take a look over the next week.
@julbinb Thanks! Will look into it and make changes where necessary.
Most of the unnecessary eval()
functions have been removed in this update.
This use of
eval
does not do anything useful:It's similar to writing
eval(3)
instead of3
. Becausem.disc_var_pick
is already a function, it would be faster to call it directly,m.disc_var_pick(m)
. For comparison, here is an example withrand
: