lanl-ansi / Alpine.jl

A Julia/JuMP-based Global Optimization Solver for Non-convex Programs
https://lanl-ansi.github.io/Alpine.jl/latest/
Other
241 stars 39 forks source link

New Feature: Linking Constraints for Multilinear Terms #203

Closed harshangrjn closed 1 year ago

harshangrjn commented 1 year ago

Suggest a feature that enables to add linking constraints for multilinear terms [1].

[1] Jongeun Kim, Jean-Philippe P. Richard, Mohit Tawarmalani, Piecewise Polyhedral Relaxations of Multilinear Optimization, 2022, http://www.optimization-online.org/DB_HTML/2022/07/8974.html

codecov[bot] commented 1 year ago

Codecov Report

Merging #203 (5b3c1db) into master (0f0c338) will decrease coverage by 0.17%. The diff coverage is 86.41%.

:exclamation: Current head 5b3c1db differs from pull request most recent head 6b09604. Consider uploading reports for the commit 6b09604 to get more accurate results

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   86.43%   86.25%   -0.18%     
==========================================
  Files          16       16              
  Lines        3193     3013     -180     
==========================================
- Hits         2760     2599     -161     
+ Misses        433      414      -19     
Impacted Files Coverage Δ
src/Alpine.jl 100.00% <ø> (ø)
src/presolve.jl 85.18% <72.22%> (ø)
src/multilinear.jl 76.56% <76.56%> (ø)
src/variable_bounds.jl 82.08% <77.50%> (ø)
src/heuristics.jl 73.07% <83.33%> (+18.69%) :arrow_up:
src/algorithm.jl 85.61% <84.14%> (-3.55%) :arrow_down:
src/utility.jl 87.79% <85.90%> (+3.32%) :arrow_up:
src/bounding_model.jl 87.66% <88.33%> (ø)
src/operators.jl 85.89% <89.36%> (-2.31%) :arrow_down:
src/MOI_wrapper/MOI_wrapper.jl 84.18% <90.10%> (-2.29%) :arrow_down:
... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

harshangrjn commented 1 year ago

207 addressed here!

odow commented 1 year ago

😢 what was the motivation for combining the PRs? Now I can't tell what the new feature is in all the noise.

harshangrjn commented 1 year ago

@odow New feature is in src/linking.jl, which I am keeping track of. :) But this will get rearranged based on more changes and tests. Should be fine. 😬