lanl-ansi / Alpine.jl

A Julia/JuMP-based Global Optimization Solver for Non-convex Programs
https://lanl-ansi.github.io/Alpine.jl/latest/
Other
241 stars 39 forks source link

Fix usage with JuMP v1.2 #205

Closed odow closed 1 year ago

odow commented 1 year ago

Potentially closes #204

Trying some other things locally as well.

odow commented 1 year ago

I guess I missed this package in my search for things that JuMP v1.2 broke. There's a bunch of internal function usage:

https://github.com/lanl-ansi/Alpine.jl/blob/fc377e6b9f1a54c9b8494e47f8472a326e6416ee/test/test_solver.jl#L306

harshangrjn commented 1 year ago

_create_nlp_block_data

This internal function usage was mainly taken from https://github.com/lanl-ansi/Alpine.jl/blob/fc377e6b9f1a54c9b8494e47f8472a326e6416ee/test/runtests.jl#L22

odow commented 1 year ago

Yeah, my work-around is to set an optimize hook so JuMP can setup everything internally, but we don't actually hit optimize!.

codecov[bot] commented 1 year ago

Codecov Report

Merging #205 (07de04b) into master (cf1f965) will decrease coverage by 0.64%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   86.88%   86.24%   -0.65%     
==========================================
  Files          16       16              
  Lines        3234     3236       +2     
==========================================
- Hits         2810     2791      -19     
- Misses        424      445      +21     
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 86.47% <ø> (ø)
src/algorithm.jl 89.27% <100.00%> (-0.28%) :arrow_down:
src/bounds.jl 82.30% <0.00%> (-2.06%) :arrow_down:
src/utility.jl 82.56% <0.00%> (-1.32%) :arrow_down:
src/amp.jl 87.71% <0.00%> (-0.88%) :arrow_down:
src/operators.jl 88.19% <0.00%> (-0.72%) :arrow_down:
src/nlexpr.jl 91.68% <0.00%> (-0.72%) :arrow_down:
src/presolve.jl 85.18% <0.00%> (-0.62%) :arrow_down:
src/multi.jl 74.36% <0.00%> (-0.37%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

odow commented 1 year ago

@harshangrjn take a look. This should be good to go now.

harshangrjn commented 1 year ago

Thanks @odow