lanl-ansi / Alpine.jl

A Julia/JuMP-based Global Optimization Solver for Non-convex Programs
https://lanl-ansi.github.io/Alpine.jl/latest/
Other
241 stars 39 forks source link

Add JuliaFormatter #207

Closed odow closed 1 year ago

odow commented 1 year ago

@harshangrjn you don't necessarily have to merge this, because the change set is massive.

But the last couple of PRs have been cluttered with style things like stripping whitespace at the end of a line (my editor does this automatically) so it might be good to have some automated formatting.

Even if you choose to merge this, you should probably merge #203 before this one, otherwise rebasing it will be a pain.

codecov[bot] commented 1 year ago

Codecov Report

Merging #207 (c30967d) into master (2a2b335) will decrease coverage by 0.08%. The diff coverage is 87.33%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   86.24%   86.16%   -0.09%     
==========================================
  Files          16       16              
  Lines        3236     3252      +16     
==========================================
+ Hits         2791     2802      +11     
- Misses        445      450       +5     
Impacted Files Coverage Δ
src/heuristics.jl 54.38% <42.85%> (ø)
src/multi.jl 73.30% <71.71%> (-1.06%) :arrow_down:
src/presolve.jl 85.18% <73.33%> (ø)
src/bounds.jl 82.37% <76.08%> (+0.07%) :arrow_up:
src/utility.jl 82.56% <81.94%> (ø)
src/tmc.jl 88.00% <87.62%> (ø)
src/algorithm.jl 89.27% <88.37%> (ø)
src/amp.jl 87.71% <90.00%> (ø)
src/operators.jl 88.21% <90.16%> (+0.02%) :arrow_up:
src/nlexpr.jl 91.46% <91.75%> (-0.22%) :arrow_down:
... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

harshangrjn commented 1 year ago

Thanks @odow I am not able to see the actual changes. If it's minimal, I will first merge PR #202 and #206 (in next few days or so), after which you can apply these changes to that.

harshangrjn commented 1 year ago

@odow #203 addresses this PR as I re-based these changes there to keep it simpler. Thanks for this suggestion. Formatting looks much neater now.