search

lanl-ansi / Alpine.jl

A Julia/JuMP-based Global Optimization Solver for Non-convex Programs
https://lanl-ansi.github.io/Alpine.jl/latest/
Other
241 stars 39 forks source link

Don't errneously claim support for `Integer` variables #245

Open LebedevRI opened 1 month ago

LebedevRI commented 1 month ago

As discussed in https://github.com/lanl-ansi/Alpine.jl/issues/244, it is counter-productive for Alpine to declare Integer variables to be supported, only to, then, produce a nice error message. This prevents IntegerToZeroOneBridge from triggering and actually providing transparent support for them..

But that requires adding support at least for MOI.is_valid(model::Alpine.Optimizer, ci::MOI.ConstraintIndex{MOI.VariableIndex,S}) and MOI.get(model::Alpine.Optimizer, ::MOI.ConstraintSet, ci::MOI.ConstraintIndex{MOI.VariableIndex,S}), but some other pieces seem missing too.

Fixes https://github.com/lanl-ansi/Alpine.jl/issues/244 Refs. https://github.com/lanl-ansi/Alpine.jl/issues/233

LebedevRI commented 1 month ago

Should this have any documentation changes? Would it be possible to get the CI feedback?

LebedevRI commented 3 weeks ago

Hm, those failures look strange, i don't think i saw them locally, but i'll re-check. Since last commit to master was 4 months ago, it might be a good idea to do a dummy commit to refresh the baseline CI status of the master branch?

odow commented 3 weeks ago

That error doesn't look related

LebedevRI commented 3 weeks ago

test (both for master and the PR) passes for me locally. Addressed formatting. Thanks for taking a look!