search

lanl-ansi / GasModels.jl

A Julia/JuMP Package for Gas Network Optimization
https://lanl-ansi.github.io/GasModels.jl/latest/
Other
65 stars 16 forks source link

ADD: Strengthening constraints for resistors and loss resistors #218

Closed tasseff closed 4 years ago

tasseff commented 4 years ago

For directed models of resistors and loss resistors, the previous implementation did not apply constraints that bounded squared pressure and mass flow variables based on flow direction. This pull request adds these constraints.

codecov[bot] commented 4 years ago

Codecov Report

Merging #218 into master will increase coverage by 0.21%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   78.25%   78.47%   +0.21%     
==========================================
  Files          35       35              
  Lines        4489     4510      +21     
==========================================
+ Hits         3513     3539      +26     
+ Misses        976      971       -5
Impacted Files Coverage Δ
src/core/constraint_mi.jl 60.81% <100.00%> (+1.20%) :arrow_up:
src/form/crdwp.jl 88.32% <100.00%> (+0.44%) :arrow_up:
src/form/dwp.jl 76.74% <100.00%> (+1.43%) :arrow_up:
src/core/constraint_template_mi.jl 69.23% <0.00%> (+3.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dca817a...7d60998. Read the comment docs.