search

lanl-ansi / GasModels.jl

A Julia/JuMP Package for Gas Network Optimization
https://lanl-ansi.github.io/GasModels.jl/latest/
Other
65 stars 16 forks source link

Encode per-unit indicator as true/false instead of 1/0 #221

Open tasseff opened 3 years ago

rb004f commented 3 years ago

This will make GasModels consistent with the conventions of PowerModels

tasseff commented 3 years ago

Additionally, for greater consistency, the field should be called per_unit instead of is_per_unit.

ccoffrin commented 3 years ago

The key per_unit is a standard https://lanl-ansi.github.io/InfrastructureModels.jl/stable/developer/ it should not be changed unless done in other packages as well.

rb004f commented 3 years ago

Correct, this issue is to make GasModels consistent with the other packages. Rename is_per_unit to per_unit and make it a boolean.