tasseff
commented
3 years ago The automated tests will not pass until the new version of InfrastructureModels is released, but this is probably sufficient for a review.
Closed tasseff closed 3 years ago
tasseff
commented
3 years ago The automated tests will not pass until the new version of InfrastructureModels is released, but this is probably sufficient for a review.
codecov[bot]
commented
3 years ago Merging #222 (d97bfd8) into master (de11ed5) will increase coverage by
0.81%. The diff coverage is83.47%.
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 77.61% 78.43% +0.81%
==========================================
Files 35 35
Lines 4571 4624 +53
==========================================
+ Hits 3548 3627 +79
+ Misses 1023 997 -26 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/GasModels.jl | 25.00% <ø> (ø) |
|
| src/core/export.jl | 100.00% <ø> (ø) |
|
| src/core/unit_converters.jl | 0.00% <ø> (ø) |
|
| src/form/dwp.jl | 76.74% <ø> (+1.74%) |
:arrow_up: |
| src/form/lrdwp.jl | 43.47% <ø> (+5.74%) |
:arrow_up: |
| src/io/diagnostics.jl | 0.00% <0.00%> (ø) |
|
| src/prob/gf.jl | 86.95% <ø> (ø) |
|
| src/prob/ls.jl | 74.41% <ø> (ø) |
|
| src/prob/ne.jl | 70.00% <ø> (ø) |
|
| src/prob/nels.jl | 68.33% <ø> (ø) |
|
| ... and 28 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update de11ed5...e38c121. Read the comment docs.
tasseff
commented
3 years ago This will close most of #226, aside from the run_ to solve_ renaming, which @ccoffrin has recommended we delay. I think it's safe for me to pass this off to the most frequent contributors for review, editing, and merging.
This pull request coincides with the
multi-infrastructurebranch of InfrastructureModels.jl.