search

lanl-ansi / GasModels.jl

A Julia/JuMP Package for Gas Network Optimization
https://lanl-ansi.github.io/GasModels.jl/latest/
Other
65 stars 16 forks source link

Stready state storage #235

Closed rb004f closed 3 years ago

rb004f commented 3 years ago

This is a proposed model for storage in steady-state. At the very least review

  1. The conversion from density to pressure. I am not convinced it is a 1-1 conversion. (see issue #234 for ref_storage)
  2. Review the (reduced) variable space and constraints for modeling storage in steady-state, and the various relaxations. It assumes the pressure-change unit is at the top of well, so the well resistance gets applied below the pressure change unit. There is one flow (fs), a constant pressure at the well base a variable pressure between the pressure-change unit and the well pipe, and the standard variable pressure at the junction (the head of the well). The pressure change unit can compress and decompress flow in either direction within bounds.
  3. Check the well resistance calculation.

Once we are converged on the model, I will update the documentation.

codecov[bot] commented 3 years ago

Codecov Report

Merging #235 (030a6b5) into master (aaab3e4) will increase coverage by 1.00%. The diff coverage is 73.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   77.88%   78.88%   +1.00%     
==========================================
  Files          34       34              
  Lines        4662     5002     +340     
==========================================
+ Hits         3631     3946     +315     
- Misses       1031     1056      +25
Impacted Files Coverage Δ
src/form/wp.jl 67.94% <15.00%> (-2.72%) :arrow_down:
src/core/variable.jl 94.97% <75.00%> (+0.50%) :arrow_up:
src/core/base.jl 93.85% <100.00%> (+0.44%) :arrow_up:
src/core/constraint.jl 100.00% <100.00%> (+5.26%) :arrow_up:
src/core/constraint_mi.jl 60.88% <100.00%> (-0.15%) :arrow_down:
src/core/constraint_template.jl 100.00% <100.00%> (ø)
src/core/data.jl 79.97% <100.00%> (+0.79%) :arrow_up:
src/form/crdwp.jl 88.65% <100.00%> (+2.22%) :arrow_up:
src/form/dwp.jl 90.80% <100.00%> (+15.80%) :arrow_up:
src/form/lrdwp.jl 63.04% <100.00%> (+25.30%) :arrow_up:
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aaab3e4...030a6b5. Read the comment docs.