search

lanl-ansi / Juniper.jl

A JuMP-based Nonlinear Integer Program Solver
https://lanl-ansi.github.io/Juniper.jl/stable/
MIT License
179 stars 22 forks source link

disable fpump in optimize! when all options are set #183

Closed Wikunia closed 4 years ago

Wikunia commented 4 years ago

Bugfix for not using fpump if mip solver exists @ccoffrin

ccoffrin commented 4 years ago

Should we add a test?

On Fri, Feb 21, 2020 at 7:31 AM Ole Kröger notifications@github.com wrote:

Bugfix for not using fpump if mip solver exists @ccoffrin https://github.com/ccoffrin

You can view, comment on, or merge this pull request online at:

https://github.com/lanl-ansi/Juniper.jl/pull/183 Commit Summary

  • disable fpump in optimize! when all options are set

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lanl-ansi/Juniper.jl/pull/183?email_source=notifications&email_token=AAIN5KTOIHPYZZNN74DCCLTRD7QULA5CNFSM4KZEGLFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPKDGOQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIN5KWLCTP4LBI4GVP5EXDRD7QULANCNFSM4KZEGLFA .

codecov[bot] commented 4 years ago

Codecov Report

Merging #183 into master will increase coverage by 1.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   91.62%   92.67%   +1.04%     
==========================================
  Files          22       22              
  Lines        1995     1993       -2     
==========================================
+ Hits         1828     1847      +19     
+ Misses        167      146      -21
Impacted Files Coverage Δ
src/util.jl 86.82% <0.00%> (+0.77%) :arrow_up:
src/printing.jl 78.94% <0.00%> (+5.26%) :arrow_up:
src/fpump.jl 91.54% <0.00%> (+6.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ff4379...bb52e6b. Read the comment docs.

ccoffrin commented 4 years ago

LGTM

Wikunia commented 4 years ago

This should probably be directly 0.6.1, right? I'll add it to the changelog then and register a new version once the tests passed.

ccoffrin commented 4 years ago

Yes. All bug fixes should be patched.