search

lanl-ansi / Juniper.jl

A JuMP-based Nonlinear Integer Program Solver
https://lanl-ansi.github.io/Juniper.jl/stable/
MIT License
179 stars 22 forks source link

Update to JuMP v0.23 and switch from Cbc to HiGHS #232

Closed odow closed 2 years ago

ccoffrin commented 2 years ago

I did notice that JuMP got back into the package deps. The objective of this PR was to remove it, https://github.com/lanl-ansi/Juniper.jl/pull/207

blegat commented 2 years ago

It's only in the test dependencies

codecov[bot] commented 2 years ago

Codecov Report

Merging #232 (9dd85ae) into master (ec81a10) will increase coverage by 0.62%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   91.68%   92.31%   +0.62%     
==========================================
  Files          20       20              
  Lines        1961     1991      +30     
==========================================
+ Hits         1798     1838      +40     
+ Misses        163      153      -10
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 88.83% <100.00%> (+4.09%) :arrow_up:
src/debug.jl 100.00% <0.00%> (ø)
src/filter.jl 100.00% <0.00%> (ø)
src/bb_user_limits.jl 100.00% <0.00%> (ø)
src/bb_inits_and_defaults.jl 100.00% <0.00%> (ø)
src/table_log.jl 95.31% <0.00%> (+0.03%) :arrow_up:
src/fpump.jl 89.62% <0.00%> (+0.04%) :arrow_up:
src/bb_integral_or_branch.jl 97.22% <0.00%> (+0.07%) :arrow_up:
src/util.jl 73.78% <0.00%> (+0.16%) :arrow_up:
src/solver.jl 79.76% <0.00%> (+0.24%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec81a10...9dd85ae. Read the comment docs.

odow commented 2 years ago

It's nice to see that HiGHS passes all the tests.