lanl-ansi / Juniper.jl

A JuMP-based Nonlinear Integer Program Solver
https://lanl-ansi.github.io/Juniper.jl/stable/
MIT License
179 stars 22 forks source link

Delete untested files in /test #235

Closed odow closed 2 years ago

odow commented 2 years ago

Closes #227

@ccoffrin not sure what you want to do with these.

There's a circular dependency with Juniper and MINLPTests. For now I've removed the MINLPTests.jl file from Juniper because it wasn't being tested in CI.

We could remove the Juniper test from MINLPTests.jl, and add a MINLPTest here instead?

codecov[bot] commented 2 years ago

Codecov Report

Merging #235 (49fed10) into master (bfb7125) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          20       20           
  Lines        2015     2015           
=======================================
  Hits         1850     1850           
  Misses        165      165           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfb7125...49fed10. Read the comment docs.

ccoffrin commented 2 years ago

How is the circular dependency managed with Ipopt.jl?

odow commented 2 years ago

Ipopt doesn't run MINLPTests

ccoffrin commented 2 years ago

In that case, I say we drop MINLPTests from Juniper to avoid the circular dep. We can try to improve MOI-tests if we find issues, right?

Re the other tests:

@Wikunia any objections in dropping current_118.jl?

odow commented 2 years ago

Judging by the syntax, it doesn't seem like the current_118 file has ever really been tested. And yes, the registration stuff is now covered by other tests.

odow commented 2 years ago

Merging for now. We can re-add the current_118 if @Wikunia objects.

ccoffrin commented 2 years ago

Sounds good to me!