search

lanl-ansi / Juniper.jl

A JuMP-based Nonlinear Integer Program Solver
https://lanl-ansi.github.io/Juniper.jl/stable/
MIT License
179 stars 22 forks source link

Prep for v0.9.0 release #237

Closed odow closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #237 (04b7e6c) into master (e6531e4) will decrease coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   91.81%   91.76%   -0.05%     
==========================================
  Files          20       20              
  Lines        2015     2015              
==========================================
- Hits         1850     1849       -1     
- Misses        165      166       +1
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 86.53% <100.00%> (ø)
src/bb_strategies.jl 99.12% <0.00%> (-0.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6531e4...04b7e6c. Read the comment docs.

odow commented 2 years ago

That looks like some sort of race condition:

image
ccoffrin commented 2 years ago

So you think a Julia bug?

odow commented 2 years ago

Could be some weird parallelism thing? I haven't dived into how Juniper does things. I'll restart the CI and see if we hit it again. If it comes up again we can investigate further.

ccoffrin commented 2 years ago

Seemed to work now. I have had similar issues on nightly Julia builds in other packages. I think we are good to proceed.