search

lanl-ansi / Juniper.jl

A JuMP-based Nonlinear Integer Program Solver
https://lanl-ansi.github.io/Juniper.jl/stable/
MIT License
179 stars 22 forks source link

Loosen tolerances in SCS conic test #241

Closed odow closed 2 years ago

odow commented 2 years ago

Previous tolerances worked for SCS v3.0.0, but we recently updated to SCS v3.2.0, which caused a CI timeout: https://github.com/lanl-ansi/Juniper.jl/commit/64b4f0c0812f37183f65d84d5ef0b3f9ba4ad2fd

I don't really understand how the tolerances work between Juniper and SCS. But just loosen them for now.

codecov[bot] commented 2 years ago

Codecov Report

Merging #241 (c59c97b) into master (d6907de) will increase coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   91.76%   91.81%   +0.04%     
==========================================
  Files          20       20              
  Lines        2015     2015              
==========================================
+ Hits         1849     1850       +1     
+ Misses        166      165       -1
Impacted Files Coverage Δ
src/BnBTree.jl 94.64% <0.00%> (+0.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64b4f0c...c59c97b. Read the comment docs.

ccoffrin commented 2 years ago

Most likely the issue is in SCS tolerances, they seem to change with every release of that solver...

ccoffrin commented 2 years ago

Thanks!