search

lanl-ansi / Juniper.jl

A JuMP-based Nonlinear Integer Program Solver
https://lanl-ansi.github.io/Juniper.jl/stable/
MIT License
179 stars 22 forks source link

Fix handling of {Primal,Dual}Status #250

Closed odow closed 2 years ago

odow commented 2 years ago

Closes #249

odow commented 2 years ago

The DualStatus thing is another surprise. I think I recall people trying to use Juniper with SDDP.jl and getting weird errors, so perhaps this was the reason.

codecov[bot] commented 2 years ago

Codecov Report

Merging #250 (f99ab61) into master (053661e) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   91.81%   91.79%   -0.03%     
==========================================
  Files          20       20              
  Lines        2015     2010       -5     
==========================================
- Hits         1850     1845       -5     
  Misses        165      165
Impacted Files Coverage Δ
src/MOI_wrapper/results.jl 86.84% <100.00%> (-1.53%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Wikunia commented 2 years ago

I'm happy to get this merged is there anything you would like to add or can this be merged @odow ?

ccoffrin commented 2 years ago

@odow, also should we add a note to the changelog?

odow commented 2 years ago

Yes, I'll add and prep a new release.