search

lanl-ansi / PowerModels.jl

A Julia/JuMP Package for Power Network Optimization
https://lanl-ansi.github.io/PowerModels.jl/stable/
Other
395 stars 148 forks source link

Data Component Id Checks #131

Closed ccoffrin closed 6 years ago

ccoffrin commented 7 years ago

When data is read in for the first time, check the component ids so make sure nothing is missing. For example, a generator or branch that references a bus that does not exists.

ccoffrin commented 7 years ago

This would go nicely with checks proposed in #51

frederikgeth commented 7 years ago

Yeah, on a related note, we already ran into such an issue with test case case3.m, with the dc line being connected between node 10 and 20. Pull request for corrected test case soon to come.

ccoffrin commented 7 years ago

Sorry about that, I added that bug in the test case to remind my self that the network was not tested for AC feasibility with this line. 😅

Happy to change it, assuming you have tested feasibility.

frederikgeth commented 7 years ago

by the way, how compatible do you want the defined test cases to be w.r.t. matpower? E.g. case3.m doesn't work in matpower (line 70, escape chars?).

ccoffrin commented 7 years ago

See #134 for an answer to your btw.

frederikgeth commented 7 years ago

ok, great.