Logic makes impedance 0.0

lanl-ansi / PowerModels.jl

A Julia/JuMP Package for Power Network Optimization

https://lanl-ansi.github.io/PowerModels.jl/stable/

Other

395 stars 148 forks source link

Logic makes impedance 0.0 #897

Open jd-lara opened 10 months ago

jd-lara commented 10 months ago

According to the PSSe manual NOMV2 is present for information purposes only; it is not used in any of the calculations for modeling the transformer. NOMV2 = 0.0 by default.

When CW = 3 this causes the value of br_x to be assigned a value of 0.0.

https://github.com/lanl-ansi/PowerModels.jl/blob/a4ca05cfbe1dd80586a7ec060e0e443867cb3adf/src/io/psse.jl#L429

jd-lara commented 10 months ago

see matpower reference https://matpower.org/docs/ref/matpower5.1/psse_convert_xfmr.html

jd-lara commented 10 months ago

@ccoffrin I implemented this fix https://github.com/NREL-Sienna/PowerSystems.jl/pull/1034/files

In essence is to employ a conditional when NOMV2 or NOMV1 are set to 0.0

KSepetanc commented 1 week ago

Should this issue be closed? The commit has been merged.