lanl-ansi / PowerModelsDistribution.jl

A Julia/JuMP Package for Unbalanced Power Network Optimization
https://lanl-ansi.github.io/PowerModelsDistribution.jl/stable/
Other
142 stars 42 forks source link

Minor typo in var dictionnary for branch power in IVR formulation #437

Closed LQ56 closed 1 year ago

LQ56 commented 1 year ago

Hello to anyone reading this,

I believe I found a minor typo in PMD while playing around with it.

When I built the model for a simple test case in PMD, I noticed that the ":p" and ":q" entries of the var dictionary were empty. (see below for a reproducible example). image

I found it a bit odd since according to the code (in the "src/form/ivr" file, line 33-34) this entry should contain the expressions of the power flowing through the branches. Looking a bit further below in this same file (lines 72-73), I noticed that the entries for the transformer branch power have the same name, and I think those dictionaries are "erasing" the previous dictionaries containing the branch power flow expression. That's why I suspect there is a typo on those lines and I believe the correct lines 72-73 should be:

image

Many thanks,