Closed zmorrell closed 2 years ago
Merging #18 (1de8723) into main (783dbf4) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 5 5
Lines 444 444
=======================================
Hits 430 430
Misses 14 14
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 783dbf4...1de8723. Read the comment docs.
My proposed updates. I broke the test into two that I think are targeting the key functionalities you were getting at.
I also tweaked the reverse annealing test parameters so that the dynamics would trigger an oscillation where the swing is captured in the final state to give a very clear signature of the impacts of the reverse schedule.
Also when writing tests I suggest that we most often hardcode the number of steps that were used to save time and make the tests more controlled experiments.
@ccoffrin This all looks good to me, I'll go ahead and merge
@ccoffrin These are the best tests that I could come up with for the reverse annealing. I'm not exactly sure what sort of behavior we would expect with this protocol, so do these tests and tolerances seem reasonable to you?