search

lanl-ansi / QuantumAnnealing.jl

Tools for the Simulation and Execution of Quantum Annealing Algorithms
Other
23 stars 5 forks source link

Revisions to Transverse Field Ising Hamiltonian builder #21

Closed ccoffrin closed 2 years ago

ccoffrin commented 2 years ago

@zmorrell, this is what I had in mind. I think most users of this feature will not need to the constant terms, so we can leave these out. Also gave the function a more descriptive name with the idea of supporting different Hamiltonians down the road. I also added some new tests targeting the constant_field capability more specifically, so that we won't regress on the bug you found.

codecov[bot] commented 2 years ago

Codecov Report

Merging #21 (b9a682f) into ham-builder (9ae8156) will increase coverage by 2.25%. The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ham-builder      #21      +/-   ##
===============================================
+ Coverage        94.59%   96.84%   +2.25%     
===============================================
  Files                5        5              
  Lines              444      444              
===============================================
+ Hits               420      430      +10     
+ Misses              24       14      -10
Impacted Files Coverage Δ
src/simulate.jl 94.59% <100.00%> (+6.28%) :arrow_up:
src/simulate_de.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ae8156...b9a682f. Read the comment docs.

zmorrell commented 2 years ago

This looks good to me. I'll go ahead and merge it into the other pull request branch