lanl-ansi / QuantumAnnealing.jl

Tools for the Simulation and Execution of Quantum Annealing Algorithms
Other
23 stars 5 forks source link

Inplace exponential #37

Closed zmorrell closed 1 year ago

zmorrell commented 2 years ago

@ccoffrin I changed the exponential to use LinearAlgebra.exp!(A) which reduces memory usage a little bit while using the exact same functionality. It should be noted that I don't think that exp! is actually truly inplace as it doesn't modify the input matrix, it just saves us a copying step that happens under the hood.

I also fixed a bug that I had found in the simulate_de code. Whenever a user passed a kwarg for solve, it would crash. While I was there I also changed it to only save the last value since we only return the final value in its current implementation anyways

codecov[bot] commented 2 years ago

Codecov Report

Merging #37 (f6b444c) into main (09d6153) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   92.86%   92.88%   +0.01%     
==========================================
  Files           5        5              
  Lines         603      604       +1     
==========================================
+ Hits          560      561       +1     
  Misses         43       43              
Impacted Files Coverage Δ
src/simulate.jl 90.44% <100.00%> (+0.03%) :arrow_up:
src/simulate_de.jl 77.55% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more