codecov[bot]
commented
4 years ago Codecov Report
Merging #118 into master will increase coverage by
9.67%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 81.13% 90.80% +9.67%
==========================================
Files 27 35 +8
Lines 2226 2566 +340
==========================================
+ Hits 1806 2330 +524
+ Misses 420 236 -184 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/WaterModels.jl | 100.00% <ø> (ø) |
|
| src/core/base.jl | 100.00% <ø> (+26.66%) |
:arrow_up: |
| src/core/constraint_template.jl | 100.00% <ø> (+19.75%) |
:arrow_up: |
| src/core/data.jl | 100.00% <ø> (+40.49%) |
:arrow_up: |
| src/core/demand.jl | 100.00% <ø> (ø) |
|
| src/core/function.jl | 100.00% <ø> (+4.00%) |
:arrow_up: |
| src/core/node.jl | 100.00% <ø> (ø) |
|
| src/core/pipe.jl | 62.63% <ø> (ø) |
|
| src/core/pump.jl | 76.47% <ø> (ø) |
|
| src/core/ref.jl | 91.89% <ø> (+4.57%) |
:arrow_up: |
| ... and 50 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8f03157...04eefc9. Read the comment docs.
@jjstickel, @dsigler1234, @rb004f, @ccoffrin: This pull request contains a large number of changes mostly aimed at increasing test coverage and making much of our recent work on bound tightening and valid inequalities more robust. There is certainly more housekeeping to do, but I think our changes to the network component model (e.g., decoupling of pipes and valves) along with the various improvements I mentioned previously warrant the release of a new version.