lanl-ansi / WaterModels.jl

A Julia/JuMP Package for Water Distribution Network Optimization
https://lanl-ansi.github.io/WaterModels.jl/latest/
Other
73 stars 11 forks source link

Expansion data file and model for expansion pumps #154

Open hskkanth opened 1 year ago

hskkanth commented 1 year ago

Parses a .neinp file to read in expansion data. Made sure constraints for expansion pumps are added the same way as regular pumps

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 31.72043% with 254 lines in your changes are missing coverage. Please review.

Project coverage is 76.71%. Comparing base (5909b8c) to head (48cb3e2).

:exclamation: Current head 48cb3e2 differs from pull request most recent head c12702f. Consider uploading reports for the commit c12702f to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154/graphs/tree.svg?width=650&height=150&src=pr&token=fAEbRz0Sxi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi)](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi) ```diff @@ Coverage Diff @@ ## v0.10-cleanup #154 +/- ## ================================================= - Coverage 80.42% 76.71% -3.71% ================================================= Files 42 43 +1 Lines 5501 5819 +318 ================================================= + Hits 4424 4464 +40 - Misses 1077 1355 +278 ``` | [Files](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi) | Coverage Δ | | |---|---|---| | [src/WaterModels.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2FWaterModels.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL1dhdGVyTW9kZWxzLmps) | `100.00% <ø> (ø)` | | | [src/form/crd.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2Fform%2Fcrd.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL2Zvcm0vY3JkLmps) | `69.62% <ø> (ø)` | | | [src/io/common.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2Fio%2Fcommon.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL2lvL2NvbW1vbi5qbA==) | `100.00% <100.00%> (ø)` | | | [src/prob/wf.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2Fprob%2Fwf.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL3Byb2Ivd2Yuamw=) | `92.47% <85.71%> (-0.31%)` | :arrow_down: | | [src/core/objective.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2Fcore%2Fobjective.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL2NvcmUvb2JqZWN0aXZlLmps) | `86.66% <77.77%> (-0.84%)` | :arrow_down: | | [src/prob/ne.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2Fprob%2Fne.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL3Byb2IvbmUuamw=) | `76.19% <50.00%> (-10.48%)` | :arrow_down: | | [src/prob/owf.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2Fprob%2Fowf.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL3Byb2Ivb3dmLmps) | `83.87% <50.00%> (-16.13%)` | :arrow_down: | | [src/form/ncd.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2Fform%2Fncd.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL2Zvcm0vbmNkLmps) | `84.98% <14.28%> (-1.53%)` | :arrow_down: | | [src/form/scip\_constraints\_variables.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2Fform%2Fscip_constraints_variables.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL2Zvcm0vc2NpcF9jb25zdHJhaW50c192YXJpYWJsZXMuamw=) | `91.17% <91.17%> (ø)` | | | [src/core/pump.jl](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree&filepath=src%2Fcore%2Fpump.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi#diff-c3JjL2NvcmUvcHVtcC5qbA==) | `61.24% <20.00%> (-2.21%)` | :arrow_down: | | ... and [2 more](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi). Last update [5909b8c...c12702f](https://app.codecov.io/gh/lanl-ansi/WaterModels.jl/pull/154?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanl-ansi).