search

lanl-ansi / qc-applications

Documentation of Applications for Quantum Computers
Other
14 stars 2 forks source link

Add support for providing resource estimates given an input arbitrarily decomposed cirq circuit #48

Closed zmorrell closed 4 months ago

zmorrell commented 4 months ago

It strikes me that it may be useful to include some functionality for returning the resource estimate for an arbitrary input cirq circuit. I am not immediately sure about how feasible this is in reality since different circuits tend to need a different number of decompositions (see for example the difference in resource requirements to decompose a trotter step as opposed to GSEE). In any case if it is easy, I think it would clean up the code in the algo_utils.estimate_trotter, and algo_utils.estimate_qsp a little bit.

I am aware that we currently have utils.circuit_estimate, but as far as I can tell upon glancing at it this morning, it doesn't work if the circuit you feed in is already fully decomposed or needs multiple decompositions.

I may be wrong - if this is the case, we should probably clean up the code in some of the functions mentioned above to make better use of utils.circuit_estimate

zmorrell commented 4 months ago

Upon further reviewing the functionality that we currently have present in the package, I think that this functionality is effectively achieved. The trotterization doesn't make sense to feed into the circuit_estimate function since it is already a logically atomic block and the circuit_estimate function attempts to decompose it further. I think that we should leave things as-is for now