search

lanl / 4DGB

4D Genome Browser project
1 stars 2 forks source link

add client tests for 'get genes for segment' and 'get segments for gene' #11

Closed dhrogers closed 3 years ago

dhrogers commented 3 years ago

Update the google actions for the client test to test the two new calls above.

Correct values for test.00 that should produce results are

get_genes_for_segment(0, 8) get_segments_for_gene(0, 'Btbd35f23') get_segments_for_gene(0, 'Btbd35f24')

I increased the 'interval' value for the test.00/project.json file in order to make this work. This shouldn't impact other tests, but if we find a problem, we will have to change things around.

ricardosida commented 3 years ago

I just created a pull request for the test_gentk file let me know if I did it correctly

dhrogers commented 3 years ago

Looks good. I merged it and deleted the branch on the server.

Take a look at the master now, and make sure it's correct. The test should be running now.

I just created a pull request for the test_gentk file let me know if I did it correctly

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/lanl/4DGB/issues/11#issuecomment-881635110, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABIX4AAOX5YPD2RCZR737UTTYB2MDANCNFSM5APZK2RA.

dhrogers commented 3 years ago

Nice work - looks like the tests all passed in the new master!

Now the workflow is going to be:

  1. add new data to the database
  2. add client and server methods to access the new data
  3. add a test to test_gentk

We're in good shape. Take a bit of time to update your slides for Monday, and we can check in at the 11am meeting.

Do you have anything to work on, or do you need something else?

Looks good. I merged it and deleted the branch on the server.

Take a look at the master now, and make sure it's correct. The test should be running now.

I just created a pull request for the test_gentk file let me know if I did it correctly

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/lanl/4DGB/issues/11#issuecomment-881635110, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABIX4AAOX5YPD2RCZR737UTTYB2MDANCNFSM5APZK2RA.

ricardosida commented 3 years ago

Sounds good! I'll start working on the presentation

Thank you -Ricardo

dhrogers commented 3 years ago

@ricardosida - can you close this issue, and add a final comment?