search

lanl / BEE

Other
13 stars 3 forks source link

Add new checkpoint-restart tests and refactor integration test code #760

Closed jtronge closed 5 months ago

jtronge commented 6 months ago

This is a WIP but I'm not adding the label so that the tests will run in CI.

I've added a new checkpoint-restart test that checks for a failure after num_tries is exceeded. I also decided to try moving the integration code from the script in ci/ into beeflow to make it easier to work with.

jtronge commented 6 months ago

The checkpoint-restart tests are not run by default, but can be started with ./ci/integration_test.py -t checkpoint_restart,checkpoint_restart_failure after starting beeflow.

pagrubel commented 5 months ago

./ci/integration_test.py -t checkpoint_restart,checkpoint_restart_failure

JFI: Didn't work until I loaded the charliecloud module, so if we make a document for running this remember to include that.

pagrubel commented 5 months ago

This looks good, thank you! @jtronge Could you put some instructions in the Readme for running the test, including ensuring charliecloud is loaded and notes about cleaning up. I see there is a new directory .beeflow-integration Also, I'm wondering if we should have a special directory for workflows that are used for integration tests. the data/cwl/bee_workflows directory has some miscelleneous workflows in it that we may want to cleanup. Putting the ones used for testing in another directory would help us know they are used for that. What do you think?

jtronge commented 5 months ago

I added a section in the developer docs with instructions for running tests locally.

I'm thinking I might put the test workflows in something like ci/test_workflows, removing them from beeflow/data. @pagrubel Do you think that makes sense?

pagrubel commented 5 months ago

I added a section in the developer docs with instructions for running tests locally.

I'm thinking I might put the test workflows in something like ci/test_workflows, removing them from beeflow/data. @pagrubel Do you think that makes sense?

Yes, that makes sense. Are they used for anything else?

jtronge commented 5 months ago

No, it doesn't look like it. I did a git grep for the workflow directory names and it didn't show any other uses.