search

lanl / BEE

Other
17 stars 3 forks source link

Stop checking job state when it's completed #892

Closed Leahh02 closed 3 months ago

Leahh02 commented 3 months ago

I tried to replicate the "NOT_RESPONDING" issue before working this, but I wasn't able to. Let me know if this fix should be sufficient to solve the problem. Also, let me know if anything should be added to the COMPLETED_STATES set. It's currently "COMPLETED_STATES = {"FAILED", "TIMEOUT", "COMPLETED"}".

pagrubel commented 3 months ago

@Leahh02 I haven't reproduced the NOT_RESPONDING state, but I do think you need to add CANCELLED to that list of COMPLETED_STATES

Leahh02 commented 3 months ago

When I tried to add my commit "45acaa7" the unit tests failed. I think it was because there was stuff added into develop and I forgot to integrate those changes into my code. So I added Krishna's and Jake's commits to my branch. If I shouldn't have done that let me know.

pagrubel commented 3 months ago

@Leahh02 Thank you this looks great. I'm just running a few of the tests we run on our overnight suite before approving.

pagrubel commented 3 months ago

Addresses issue #874