Closed RyanWollaeger closed 3 years ago
Merging #1114 (9e90c03) into develop (385284a) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #1114 +/- ##
=======================================
Coverage 88.9% 88.9%
=======================================
Files 373 373
Lines 19570 19570
=======================================
Hits 17416 17416
Misses 2154 2154
It appears one coverage check is not passing. Going to try rebasing this PR against develop to see if it is avoidable.
It appears one coverage check is not passing. Going to try rebasing this PR against develop to see if it is avoidable.
Don't bother with the rebase. The coverage is still good. If this is ready, let's just merge it.
It appears one coverage check is not passing. Going to try rebasing this PR against develop to see if it is avoidable.
Don't bother with the rebase. The coverage is still good. If this is ready, let's just merge it.
Sorry - missed your comment and just rebased (doesn't hurt I suppose).
LGTM
Background
Purpose of Pull Request
matid
field in the main X3D file is consistent with the region file cell partitioning (but the region file enumeration - Reg1, Reg2, etc - is not equal to the matid value per region).Description of changes
--reg_ids
is a list of matids per region,--reg_bnd_per_dim
is a serialized list of boundaries dimensions, similar to--bnd_per_dim
but for each value in--reg_ids
(in the same order).Status