lanl / Draco

An object-oriented component library supporting radiation transport applications.
Other
55 stars 44 forks source link

Add option to generate arbitrary rectangular (prism) regions. #1114

Closed RyanWollaeger closed 3 years ago

RyanWollaeger commented 3 years ago

Background

Purpose of Pull Request

Description of changes

Status

codecov[bot] commented 3 years ago

Codecov Report

Merging #1114 (9e90c03) into develop (385284a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1114   +/-   ##
=======================================
  Coverage     88.9%   88.9%           
=======================================
  Files          373     373           
  Lines        19570   19570           
=======================================
  Hits         17416   17416           
  Misses        2154    2154           
RyanWollaeger commented 3 years ago

It appears one coverage check is not passing. Going to try rebasing this PR against develop to see if it is avoidable.

KineticTheory commented 3 years ago

It appears one coverage check is not passing. Going to try rebasing this PR against develop to see if it is avoidable.

Don't bother with the rebase. The coverage is still good. If this is ready, let's just merge it.

RyanWollaeger commented 3 years ago

It appears one coverage check is not passing. Going to try rebasing this PR against develop to see if it is avoidable.

Don't bother with the rebase. The coverage is still good. If this is ready, let's just merge it.

Sorry - missed your comment and just rebased (doesn't hurt I suppose).

brryan commented 3 years ago

LGTM