Fix warnings issued by Intel OneAPI 2021.4.0

[KineticTheory]

Background

• We are adding support for Intel OneAPI compilers for Crossroads. This change-set eliminates build warnings for Release builds.
• These changes seem to also eliminate all build warnings for Debug flavor.

Purpose of Pull Request

• Fixes re-git issue #56

Description of changes

• Always build with -fp-model=precise
• Provide copy constructors and copy assignment operators for classes that have explicit destructors.
• Remove variables that are defined and set, but not read.
• Add pragmas to quiet warnings for vendor code.

Status

• Reference:
  • Pre-Merge Code Review
  • CDash Status
• Checks
  • [x] Travis/Appveyor CI checks pass
  • [x] Code coverage does not decrease
  • [x] Valgrind test passes
  • [x] Toss3 checks pass
  • [x] Trinitite checks pass
  • [ ] Code reviewed/approved, sufficient DbC checks, testing, documentation

[codecov[bot]]

Codecov Report

Merging #1145 (a6b5716) into develop (b8e3bcd) will increase coverage by 0.0%. The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #1145   +/-   ##
=======================================
  Coverage     89.0%   89.0%           
=======================================
  Files          374     374           
  Lines        19263   19268    +5     
=======================================
+ Hits         17155   17162    +7     
+ Misses        2108    2106    -2     

[certik]

There is still one warning, treated as error:

[ 25%] Building CXX object src/linear/CMakeFiles/Lib_linear.dir/qrdcmp_pt.cc.o
/home/travis/Draco/src/mesh_element/Element_Definition.hh:262:3: error: use '= default' to define a trivial copy constructor [modernize-use-equals-default,-warnings-as-errors]
  Element_Definition(Element_Definition const &rhs)
  ^
2810 warnings generated.
Suppressed 2809 warnings (2809 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
make[2]: *** [src/mesh_element/CMakeFiles/Lib_mesh_element.dir/build.make:82: src/mesh_element/CMakeFiles/Lib_mesh_element.dir/Element_Definition.cc.o] Error 1

Otherwise it looks good.

[KineticTheory]

Otherwise it looks good.

Should be fixed by c156e7f.