Issues Fixed V3.1 - Githubissues

Issues added by bulk in conversion from Mercurial to github

These are fixed Issues edited from Release_notes_V3.1.0.txt (Removed changesets not related to code fixes)

Version 3.1.0 Jan 29 2008 to Aug 20 2012

@465:8b356280cfe7 3 weeks spchu
rename params_eosco2 to params_eosco2.h to be used by co2_fugacity.f

@464:e9d99e2042a8 3 weeks spchu
rename params_eosco2 to params_eosco2.h to be used by co2_fugacity.f

08/16/12

@463:f90e801271bc 4 weeks spchu
Added fix to set ifxconc correctly when using pH.

@462:79484e04dce0 4 weeks spchu
remove params_eosco2.h, renamed it to be params_eosco2 which is not an object file needed to be included in the depends file

08/09/12

Matthew Schauer enhancements to combine trac and rxn to macro trxn. This commit incorporates a number of major updates and revisions to the trxn macro. The macro is now current with the documentation on the manual wiki at

06/07/12

@442:09c58b87244b 3 months kelkar
stressctr.f debuged the input of flag_element_perm on the same line as the macro 'fem'

08/14/12 change version tag to 3.1.1

%%%%%%% VERS3.1.0_012_0418 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% In order to better synch version numbers embedded in the code and documentation Change this version to 3.1.0 instead of 3.00 and continue on with versions 3.1.*

@407:ea3d18147a29 5 months zvd Added output of node number along with number of connections. Code now reports itis stopping once the connections list is written.

03/27/12

@406:357f079c5f5b 6 months zvd Fix improper assignment of function return value for the cden correction.

@399:c7d066d87687 6 months zvd Coding was added to compute concntration flux for vapor species. A correction was made to use the correct index for density, volume, saturation and porosity.

@398:f52723379110 6 months zvd Fixed output order problem (unformatted output) for particle numbers by species for mptr simulations. Modified code to only output information for the number of particles for a given species. Previously output was controlled by number of particles that species 1 had.

03/29/12

@396:405f3078f079 6 months zvd Corrected header for sptr btc output when keywords 'alt' and 'xyz' are used.

%%%%%%% VERS3.0_012_0418 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

02/02/12 Release V3.1.0 Distribution for Linux and Mac, Zora compile

01/25/12

@383:3a92ca4a69b7 8 months zvd Fixed argumnet mismatch in subroutine calls from these routines.

@382:16f30f45fcff 8 months zvd Removed duplicate specification for use of variable ipermstr2 from module comsi.

12/20/11

@378:007efc7a9355 9 months zvd Modifications to keep in sync with EM version of FEHM and correct minor issues.

11/29/11

@376:32308f3a8a76 10 months zvd Fixed variable assignment for CO2 gas density and viscosity output. Added time option where hours can be fully spelled out instead of abbreviated.

@375:f2c1d491a8a1 10 months zvd Fixed output flag to only output enthalp fluxes when available in simulation.

@373:2f4406f401f8 10 months zvd Corrected derivative sign for CO2 liquid variable in relative perm calculation.

@372:9ef263594766 10 months zvd Corrected allocation of local variable to match size of global equivalent. Mismatch in size caused crash on deallocation.

11/08/11

@343:ba11f03c899d 10 months zvd Added back in co2 flow option inadvertently ommited during merge due to duplicate use of a flag ID.

@342:153f2c936819 10 months zvd Corrected problem with zone definitions for dpdp problems, where auto-generated zones overwrote user defined zones for the matrix. Do not want to auto-generate the matrix node zones if the user has created their own zone definitions.

%%%%%%% VERS3.00 Nov 2011 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% 10/31/11 TAG V3.1 with docs V3.0

@334:02c2b58b566f 11 months zvd Add correct (and correctly named version) of gdkm_connect for new generalized double porosity / double permeability model.

@329:06c630827fd1 11 months zvd Correct second index for particle concntration calculation.

@328:36aaf420510a 11 months zvd Add coding to output multiple species for mptr problems. Original version only output data for species 1 in a multiple species particle tracking simulation.

09/06/11

@318:677914dbd67b 12 months zvd Added logic to set default control file, error file, and check for command line only if this is not a GOLDSIM linked run with input parameter in(4) = 666.

@317:6851cfaf2c16 12 months zvd Modify part_track output to include cumulative time when outputting particle location (pout = -7) and correct header to reflect the values output to file for that option.

@315:8c7532e1126e 12 months zvd Fix scanning routine so code is reading correct unit if the rlpm macro is entered in an optional file. Add check to scanning of particle restart data to determine if zbtc data was written so particle count is calculated correctly.

07/18/11

@310:35626defa85f 14 months zvd Correct input unit number so rlpm macro can be correctly read/scanned from an external file.

06/23/11

@308:fcf58778ce0f 15 months zvd Modified conditional checks to allow capillary pressure output when ico2 > 0 or irdof ne 0 or ifree ne 0. Was not outputting capillary pressure for isothermal air/water problem.

05/17/11

@296:6096cf50b73d 16 months rajesh
Changed model for calculation of fugacity in co2_properties module. Went back to the earlier formulation based on Span and Wagner. Added a new subroutine 'co2_fugacity.f'. Made appropriate changes for calling co2_properties in other subroutines. Changed the order of call for icectrco2 and ther_co2_h2o in bnswer, varchk and startup This was done because the fugacity formulation requires density which is calculated with ther_co2_h2o with flag 0. Changed the formulation for calculating heat outflow bc in ther_co2_h2o. Modified output of zone fluxes.

04/19/11

@288:d0b23d00790f 17 months zvd Fixed cast of type where real value was used in calculation of an index for the in array.

@287:66748f5a4aed 17 months zvd Made some corrections to allocation (only allocate if unallocated) and assignment of "in" array (only check wtrise if linked to GoldSim?). Changes were needed with respect to adding "in" to comuserc.

@286:a82bc5f39580 17 months zvd Made call sequence consistent with subroutine for call to max_excess_shear.

02/07/11

@270:c61cb1fc89e9 20 months sai Added routines for stress computations in 2-D using 'fem' Fixed a minor bug in the bodyforce computations

01/19/11

@264:2910c24a437b 20 months zvd Add coding that changes check for number of nodes found in restart file compared to nodes in code because for a gdpm problem additional nodes do not have to be in increments of neq_primary like for dpdp or dual problems.

@262:3da2f4ae9cbe 20 months zvd Corrected assignment of end-point values for linear rlp and capillary pressure models.

@260:5e139ecc1183 20 months zvd Changes to fix problems with sptr. In insptr insure dtmin is set to positive value, and freeze_time is correctly initialized. In ptrac3 add warning for illegal particle moves and check to make sure that for sptr2 for plumecalc output only occurs when a particle leaves a cell. For move particle remove old coding for random walk jumps in regular grids that erroneously exited loop at edge nodes. Add bilinear interpolation routine for type curve interpolation.

12/21/10

@256:931efcd15b69 21 months zvd Per gaz finding, moved assignment of alpha and beta before conditional for rlp or capillary calculation. Previously they were undefined on return call to routine for calculation of capillary pressure (model 19).

@255:a55823a3ce56 21 months zvd Added coding from Lagrit parse_string routine to correct problem where the parser was identifying a string made up of integers and "-" as an integer instead of a string.

@250:e6d7421d20f4 21 months gaz added capability to manage far-field boundary conditions (comai,combi,data,scanin, input,gensco2h2o.f) fixed errors in vgcap and rlperm_co2

@230:763bcf14d21c 22 months zvd Corrected accumulation terms for solute diffusion. For solute diffusing into or out of a cell a positive change in the cell concentration should be added to the sumin and a negative subtracted from the sumout.

11/01/10

ther_co2_h2o.f small corrections for Co2 energy term (and production term)

@244:f9af6e74318b 2 years gaz corrected bug in shape function routine changed the definition of volumes generated in gncf3 to match that needed for body forces added test routine in user_ymp.f

@242:0760302730bd 2 years gaz Corrected co2 production terms

@241:956a0f8937b5 2 years gaz fixed errors

@240:430cd04846e2 2 years gaz fixed bugs in CO2 code (geneq_co2.f,geneq_h2o_co2.f,gensco2h2o.f,ther_co2_h2o.f,etc fixed a minor bug in vgrlps.f fixed minor bug in steady.f

10/12/10

@228:f7a9b83f39be 2 years zvd Fixed co2 code to correct enthalpy terms for water and co2 fluxes. Fixed upper limit check for saturation in vgrlps.

@227:d63d8d72c24d 2 years zvd Add check to ensure that the water saturation used to compute diffusion is between 0. to 1.0 so diffusion is computed correctly. Saturations lieing outside that range can lead to NaN's being computed and bad results.

06/24/10

@216:4138aed9d7b1 2 years zvd Resolve inconsistencies found on merge of open code with ExxonMobil? base code.

@212:901945ec7f50 2 years gaz made changes to stress calc routine added more sterss coefficients (stress averaging) added changes for tensor perm and heat and mass flow added partial fix for spatially variable GDKM minor fix for peaceman well

@204:19fd1184147f 2 years zvd Corrected indexing problem with particle output when particle restarts are used for the minimal (plumecalc style) sptr2 output. Also, added option to only output final particle location when particle time is greater than simulation time if an output end flag is set.

@203:73e4bd7e4863 2 years zvd Corrected type decalrations for ncon and nop to integer in the routine to match the variables being passed in.

@201:25f08da112b6 2 years zvd Corrected trac output for Henry's Law species. For history output, the concentration values output were correct for the model component, but the headers were wrong for vapor species - reporting output as aqueous instead of vapor. For contour output, the aqueous values were always output instead of the vapor concnetrations when a vapor species was used.

03/04/10

@210:d8ac62b7e519 3 years gaz Fixed minor out of bounds

@209:c3913611527b 3 years gaz add_gdpm.f : added new model and minir changes area_flow_bc.f : added calculation of control volume lengths in all directions bnswer.f : changed call to outbnd comai.f : added global variables resetv.f : minor bug fix gradctr.f : additional capability

@196:d65de61536c1 3 years zvd Corrected incorrect input unit designator in reads for 'well' macro, so data can be correctly read from an alternate input file.

@195:3b1a11d08006 3 years zvd Fixed terminal and output file headers for flux output to match new format of zone flux output.

@194:c5d98ca2644c 3 years zvd Fixed indexing variable so zone idnetifiers are written correctly to output title string.

@193:0f42bf2d586f 3 years zvd Fixed default conditions for macro flxz so that vapor output is not enabled for wtsi problems.

@189:f17bcc17d5e8 3 years zvd Corrected incorrect goto location when rxn macro and zone output are used.

@188:e50237e91734 3 years zvd Fixed time reporting problem when using transient particle release with initial simulation time greater than particle release time. Particle movement is now related to initial simulation time, if greater than particle release time.

@187:7b2df28fe5e5 3 years zvd Add correction for calls to solve_new and solve_dual when igauss = 1.

@185:ce2bfb5e1f89 3 years zvd Fixed problem with coordinate output in vector file when 2D geometry is not in terms of XY but XZ or YZ.

@181:b3fce545cb9c 3 years gaz Resolved small (rlp= -4) in rlperm.f inpyt and scanin have only small changes.

@178:d30fa951c93d 3 years zvd Modified 0. arguments to max function, wouldn't compile on intel MAC using absoft compiler due to type mismatch.

@173:952cd9c4bb7f 3 years zvd Fixed index for output in diagnostics and gensdp_switch. Checked for open output file in infiles before write. Added allocatio for unallocated stress parameters.

@168:8a905759b5ab 3 years 090334
minor changed to data checkin

10/20/09

@166:7b0ba975a79c 3 years gaz airctr.f changes to control phase changes (could be important) comai.f added parameters data.f set default values for some ne phase change control parameters input.f added new input macro ittm for pase change sticking time stress_perm.f minor corrections structured.f added routine to generate an element file (not tested!) user_ymp.f added case 455 (covert NER data to permeabilities) write_avs_node_con.f,write_avs_node_mat.f,write_avs_node_s.f - read,write elem(for fdm) to graphics file.

@165:fdf5952c2f68 3 years zvd Made changes to rdcon to check for 0 or negative porosities when distributing input moles in a zone. Fixed incorrect goto label for zone output for transport with reactions in write_avs_node_con. Added better conditional check for air/vapor flux output to ensure phase is present and variables have been defined in input and flxz.

@164:4c8a9148607d 3 years zvd Commit changes from merge and add modifications to output head values in history and countour files when using chead macro, and add vapor zone flux output and keywords to select zone flux phase for liquid-air/vapor problems.

@163:f0c8b606e975 3 years zvd Correctly set vboun flag and modify to allow 0 volume input.

@162:7b52ff7b1b6d 3 years zvd Remove extraneous commas from write statements in compute_exit_new and steady. Add back in density assignment to rolf in ther_co2_h2o that is needed for correct functioning of transport.

@161:58a7322b14d1 3 years zvd Commit changes from merge, updated Makefile.depends for modified common file and new file added, fixed call to subroutine max in stress_perm so data types matched.

@159:17cd9ad6e50b 3 years gaz correction for writing head output added sticking parameter for phase changes

@155:4ffa96d8bab4 3 years zvd Modified comsteady, steady to output steady state message for each output time. Fixed problem in write_avs_node_s that was causing double zone headers to be written when xyz output was invoked.

@150:c77f49df78bd 3 years gaz airctr.f -insignificant cganges bcon.f - added ifree.eq.0 comriv.f - added more well variables comriv.f - added and passed through implicit well variables geneq1.f - small change for river or well connections (only for iriver=2) geneq2_wtsi.f - small change for river or well connections (only for iriver=2) geneq_stress_uncoupled_2D.f - minor changes geneq_stress_uncoupled_2D_FEM_rad.f - minor changes geneq_stress_uncoupled_3D.f - minor changes gensl2.f - insignificant changes implicit_well2.f - cleaned up generation of well segments plot_new.f - don't know plot_new.f rlperm_wtsi.f - commented out per iteraioin output startup.f- don't know stress_2D_post.f - minor stressctr.f - minor user_ymp.f - added case 455 permeabilty data conversion to fehm input wtsictr.f - minor

@149:6b303a0dfd09 3 years zvd Corrected initializations so multiple boun macros in an input deck would work correctly. For PC corrected inconsistencies between versions of the fehmn subroutine.

@147:b51ac15eb065 3 years zvd Add additional output options for CO2 (mass fraction) and minor bug fixes in logic.

@146:3be075e24044 3 years zvd Correct logic for output of relative displacements for history plots.

@144:ce08bedefe10 3 years zvd Updates to history output for addition of CO2 pressure output and split of pressure output into multiple files.

@143:d1afc7e95636 3 years gaz changes to improve efficiency for anisortropy calcs merged keita's changes to stress perm

@142:f846be920e37 3 years zvd Minor fixes that were not correct from last update: fehmn.f modified to match fehmn_pcx.f, missing conditional in stress_perm and type conversion fixes, and delete unnecessary variables from geneq_stress_uncoupled_2D.

@141:4649c1a16f56 3 years gaz miscellaneous snall corrections and corretcions for running heat conduction with stress

@140:6b5e47c7d50a 3 years gaz corrected files for anisotropy, wells, and minor changes to stress solution

@138:db1aea21180a 3 years zvd Miscellaneous fixes: cntlio - fixed read of usub_num to be non formatted integer, comai & cntlio - implemented flag to suppress output of nodal equation residuals, storsx & storsx_write - fixed file checks and assignments, wellphysicsctr - added check to see if variable is already allocated, flxz, inhist & plot_new - fixed output headers, etc and variables for co2, split co2 saturations into two output files.

@137:5915093c3de5 3 years zvd Fixes for stress with thermal only simulation. Use conditional idoff .eq. -1 for check.

@136:d211cc0d3323 3 years zvd Fixes to routines for stress used with thermal only simulation. Corrected conditional checks from idof .le. 1 to idoff .eq. -1.

@131:45e9e733a21c 3 years zvd Minor modifications to correct line length, position of continuation character, change to real variable where integer was used incorrectly used.

06/18/09

@122:d5650132fc95 3 years zvd These modifications include changes to fehmn.f for FEHM V2.26 modifications and the sptr module updates. Also included are modifications to improve/correct the functionality of a free drainage condition (inflo3.f), new sub-model input and output functionality (input.f, submodel_bc.f), data updates (data.f, setparams.f), fixes/changes to output logic (flxz.f, cflxz.f, write_avs_node_con.f, wrtout.f) and any other associated changes to variables or logic.

@121:ffea1a9199e7 3 years zvd These modifications incorporate changes to the sptr module including an alternate output format for breakthrough (added for FEHM V2.26) and updates to improve code performance and behavior when particles move into poorly connected regions of the grid created by addition of zero porosity nodes. Changes have also been made to sptr2 output to be used with PLUMECALC.

@120:14d4e4d22fd0 3 years zvd These changes incorporate the functionality and fixes incorporated in YMP qualified version FEHM V2.26. It includes a variable permeabilty option in the boun macro and a solute recirculation with erosion model. Logic corrections were made in the GoldSim? coupled model for colloid filtration where the random number used was incorrectly set and the full colloid distribution was not sampled, and to correctly apply a change in water table elevation.

@96:2a1ebe2796c9 3 years gaz committing files with minor cosmetic changes

@95:47f9587aae44 3 years gaz added correct date stamp

@94:397af23187c4 3 years gaz removed some unused code that was there for testing

@76:c6aa26cb636a 3 years zvd Corrected problem caused by attempt to output undefined variable pcp.

03/30/09 Version 3.00

lanl / FEHM

Issues Fixed V3.1 #2