search

lanl / FEHM

Finite Element Heat and Mass Transfer Code
https://fehm.lanl.gov
Other
52 stars 18 forks source link

FehmPyTests Fail #50

Open ehinrichs opened 4 months ago

ehinrichs commented 4 months ago

The fehmpytests, boun (incorrect hydrolic head at time 2.0), cellbased (global name not defined), colloid_filtration (missing valid comparison file), and ppor_read (no file), fail when running fehmpytest.py. They were commented out in the test suite, but making an issue for documentation.

millerta commented 2 months ago

Phil Stauffer identified critical and high priority tests to add from George's test suite.

Table with list of test cases and status is maintained locally private to LANL at: https://docs.google.com/spreadsheets/d/1JnmglaLt7Xc0GLzIT565Fy0PxO--6fSM4ltrpDGyJao/edit?gid=0#gid=0

FEHM EXECUTABLE VERSION:

From Xiang win-executable is FEHM V3.6.2

From Terry  FEHM V3.6.2 compiled June 20, linux compile from george V3.6.2
/project/eesdev/FEHM/FEHM_FORK/FEHM_gaz-linux/src_build/xfehm

FEHM TEST SUITE VERSION:

Use George's final VV test suite labeled V3.4 at
/project/eesdev/FEHM/VV_TESTS/VERIFICATION_V3.4win_64bit_runs_050724

Terry is Running on servers with fehmpytests from Master
/project/eesdev/FEHM/FEHM-fehmpy/fehmpytests
millerta commented 5 days ago

Scripts are running well in general. See issues for individual test cases that fail.

Output can be improved so it is more concise and consistent. Currently there is a lot of extra screen output and it is hard to see what is working and what is not. Separate FAIL (compare output fails) from run-time ERROR such as fehm early exit where comparisons were not done

It would be nice to have default output be concise with an optional -verbose available. The user should see just the test case names one line each, or single long line as the number increases.

avdonin ...ok baro_vel ...ok boun ...fail doe ...fail boun ...ok bodyforce ...ok cellbased ...error heat3d ...ok

***********************************************
Executable: ../src/xfehm
Date: 19 Sep 2024
Running tests: default
***********************************************
avdonin ... ok
baro_vel ... ok
boun ... fail
doe ... fail
cellbased ... error
doe ... fail
bodyforce ... ok
fracture_aperture ... ok
head ... ok
heat2d ... ok
heat2d_quad ... ok
heat3d ... ok
heatflux_1DConvection ... ok
heat_pipe ... ok
henrys_law ... ok
rad_decay ... ok
uz_test ... error
vapor_extraction ... ok
wvtest ... error
***********************************************
Ran 36 tests in 480.456s
FAILED (failures=3, errors=3)

FAIL: boun
FAIL: doe rlpm
FAIL: doe table
ERROR: uz_test fehm early exit
ERROR: cellbased fehm early exit
ERROR: wvtest missing files