search

lanl / LaGriT

Los Alamos Grid Toolbox (LaGriT) is a library of user callable tools that provide mesh generation, mesh optimization and dynamic mesh maintenance in two and three dimensions.
https://lanl.github.io/LaGriT/
Other
116 stars 48 forks source link

tinerator : Some delineation methods require additional arguments #149

Closed zgxn closed 5 years ago

zgxn commented 5 years ago

@daniellivingston In the function watershed_delineation in dem_class, the methods Holmgren and Freeman require specification of an exponent. Currently, tinerator does not provide a way of doing it. A possible fix would be to add an optional argument exponent:float to the method, and propagate it downwards. I have verified that using an exponent argument for methods that do not require one, e.g. 'D8' creates no conflict in RichDEM.

daniellivingston commented 5 years ago

Great point and thanks for picking up this oversight. We'll have to figure out some way to manage this in interactive mode.

Fixed in #150 - closing