search

lanl / LaGriT

Los Alamos Grid Toolbox (LaGriT) is a library of user callable tools that provide mesh generation, mesh optimization and dynamic mesh maintenance in two and three dimensions.
https://lanl.github.io/LaGriT/
Other
116 stars 48 forks source link

Remove pexpect #196

Closed banesullivan closed 4 years ago

banesullivan commented 4 years ago

Resolve #195

This removes the pexpect package from being included - it isn't good practice to have it that way. Version 4.6.0 (the version that was included) is available on PyPI: https://pypi.org/project/pexpect/4.6.0/ and should be installed from pip

This also:

Todo

The Python module isn't tested on Travis?... It looks like tests and examples are all written but they aren't verified on Travis.

Should I use this pull request to implement installing the Python module and running those tests and examples to verify everything works?

daniellivingston commented 4 years ago

Assuming this has no downstream effects (probably a safe assumption), then I support this PR

banesullivan commented 4 years ago

Thanks for the support, @daniellivingston! I'd like to make sure this is all tested before merging... Should I give a go at running all the examples and the test suite on Travis?

daniellivingston commented 4 years ago

Travis would likely fail; we have some breaking changes in our test suite at the moment. There is a PyLaGriT test folder that should pass, though.

But work with @dharp on this: PyLaGriT is his project, and he'll be the one to approve/reject/modify this PR :)